* [PATCH] usb: bluetooth: get lock before calling usb_[disable|enable]_autosuspend()
@ 2021-08-02 22:14 Salah Triki
2021-08-03 5:37 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Salah Triki @ 2021-08-02 22:14 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz, gregkh
Cc: linux-bluetooth, linux-kernel
Based on the documentation of usb_[disable|enable]_autosuspend(), the
caller must hold udev's device lock.
Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
drivers/bluetooth/btusb.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index a9855a2dd561..2ceb48164b6d 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -1939,8 +1939,11 @@ static int btusb_setup_csr(struct hci_dev *hdev)
device_set_wakeup_capable(&data->udev->dev, false);
/* Re-enable autosuspend if this was requested */
- if (enable_autosuspend)
+ if (enable_autosuspend) {
+ usb_lock_device(data->udev);
usb_enable_autosuspend(data->udev);
+ usb_unlock_device(data->udev);
+ }
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] usb: bluetooth: get lock before calling usb_[disable|enable]_autosuspend()
2021-08-02 22:14 [PATCH] usb: bluetooth: get lock before calling usb_[disable|enable]_autosuspend() Salah Triki
@ 2021-08-03 5:37 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-08-03 5:37 UTC (permalink / raw)
To: Salah Triki
Cc: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
linux-bluetooth, linux-kernel
On Mon, Aug 02, 2021 at 11:14:29PM +0100, Salah Triki wrote:
> Based on the documentation of usb_[disable|enable]_autosuspend(), the
> caller must hold udev's device lock.
>
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> ---
> drivers/bluetooth/btusb.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index a9855a2dd561..2ceb48164b6d 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -1939,8 +1939,11 @@ static int btusb_setup_csr(struct hci_dev *hdev)
>
> device_set_wakeup_capable(&data->udev->dev, false);
> /* Re-enable autosuspend if this was requested */
> - if (enable_autosuspend)
> + if (enable_autosuspend) {
> + usb_lock_device(data->udev);
> usb_enable_autosuspend(data->udev);
> + usb_unlock_device(data->udev);
> + }
> }
> }
>
> --
> 2.25.1
>
As was pointed out elsewhere, this is not correct.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-03 5:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-02 22:14 [PATCH] usb: bluetooth: get lock before calling usb_[disable|enable]_autosuspend() Salah Triki
2021-08-03 5:37 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox