From: Salah Triki <salah.triki@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Amey Narkhede <ameynarkhede03@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: gdm724x: get lock before calling usb_[disable|enable]_autosuspend()
Date: Mon, 2 Aug 2021 23:37:03 +0100 [thread overview]
Message-ID: <20210802223703.GA1425480@pc> (raw)
Based on the documentation of usb_[disable|enable]_autosuspend(), the
caller must hold udev's device lock.
Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
drivers/staging/gdm724x/gdm_usb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/gdm724x/gdm_usb.c b/drivers/staging/gdm724x/gdm_usb.c
index 54bdb64f52e8..31b3b3e563c8 100644
--- a/drivers/staging/gdm724x/gdm_usb.c
+++ b/drivers/staging/gdm724x/gdm_usb.c
@@ -846,7 +846,9 @@ static int gdm_usb_probe(struct usb_interface *intf,
udev->intf = intf;
intf->needs_remote_wakeup = 1;
+ usb_lock_device(usbdev);
usb_enable_autosuspend(usbdev);
+ usb_unlock_device(usbdev);
pm_runtime_set_autosuspend_delay(&usbdev->dev, AUTO_SUSPEND_TIMER);
/* List up hosts with big endians, otherwise,
--
2.25.1
next reply other threads:[~2021-08-02 22:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 22:37 Salah Triki [this message]
2021-08-03 5:16 ` [PATCH] staging: gdm724x: get lock before calling usb_[disable|enable]_autosuspend() Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210802223703.GA1425480@pc \
--to=salah.triki@gmail.com \
--cc=ameynarkhede03@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox