Re: [PATCH] staging: r8188eu: Fix different base types in assignments and parameters

Fabio M. De Francesco
2021-08-02T15:21:21Z

On Monday, August 2, 2021 4:26:33 PM CEST Fabio M. De Francesco wrote:
> On Monday, August 2, 2021 4:05:05 PM CEST Dan Carpenter wrote:
> > On Fri, Jul 30, 2021 at 08:14:52PM +0200, Fabio M. De Francesco wrote:
> > > Fix sparse warnings of different base types in assignments
> > > and in passing function parameters.
> >
> > [...]
> > >
> > > + union {
> > > + unsigned int f0;
> > > + unsigned char f1[IPX_NODE_LEN];
> >
> > What is going on here?? Why is f1 six bytes?
>
> Please look at the third parameter of the latest memcpy() in this function.
>

No, I'm wrong here. I must have exchanged in my mind the latest and the
memcpy() before the latest. So I see a '6' in the wrong memcpy().

I'll fix it ASAP.

Thanks,

Fabio