Re: [PATCH 03/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_mlme_ext.c

Dan Carpenter
2021-08-09T14:56:27Z

On Sat, Aug 07, 2021 at 12:11:05PM +0200, Michael Straube wrote:
> @@ -1855,12 +1855,12 @@ void issue_p2p_GO_request(struct adapter *padapter, u8 *raddr)
> pframe += sizeof(struct rtw_ieee80211_hdr_3addr);
> pattrib->pktlen = sizeof(struct rtw_ieee80211_hdr_3addr);
>
> - pframe = rtw_set_fixed_ie(pframe, 1, &(category), &(pattrib->pktlen));
> - pframe = rtw_set_fixed_ie(pframe, 1, &(action), &(pattrib->pktlen));
> - pframe = rtw_set_fixed_ie(pframe, 4, (unsigned char *)&(p2poui), &(pattrib->pktlen));
> - pframe = rtw_set_fixed_ie(pframe, 1, &(oui_subtype), &(pattrib->pktlen));
> + pframe = rtw_set_fixed_ie(pframe, 1, &(category), &pattrib->pktlen);
^^^^^^^^^^^
These should be removed as well.

> + pframe = rtw_set_fixed_ie(pframe, 1, &(action), &pattrib->pktlen);
^^^^^^^^
> + pframe = rtw_set_fixed_ie(pframe, 4, (unsigned char *)&(p2poui), &pattrib->pktlen);
> + pframe = rtw_set_fixed_ie(pframe, 1, &(oui_subtype), &pattrib->pktlen);
^^^^^^^^^^^^^^

All the third parameters of rtw_set_fixed_ie() in this patch really.

> pwdinfo->negotiation_dialog_token = 1; /* Initialize the dialog value */
> - pframe = rtw_set_fixed_ie(pframe, 1, &pwdinfo->negotiation_dialog_token, &(pattrib->pktlen));
> + pframe = rtw_set_fixed_ie(pframe, 1, &pwdinfo->negotiation_dialog_token, &pattrib->pktlen);
>
> /* WPS Section */
> wpsielen = 0;

regards,
dan carpenter