From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 178C9C432BE for ; Mon, 9 Aug 2021 16:51:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F221560F56 for ; Mon, 9 Aug 2021 16:51:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234057AbhHIQvh (ORCPT ); Mon, 9 Aug 2021 12:51:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233622AbhHIQvR (ORCPT ); Mon, 9 Aug 2021 12:51:17 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4539C0617A0 for ; Mon, 9 Aug 2021 09:50:54 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id m12so22303437wru.12 for ; Mon, 09 Aug 2021 09:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gfdfOq3fPaEyVy8vIu1pAlj6ZJZ6BE3vB+0GWCKQYmQ=; b=RKU4yacVmm8Lx3VEDg85AiVVqsnpvCsijrh7W/F+I30xYicCItP22F7hpTu8SD9Knm Jo7JGbfnqzIzHNAkhC03vApc5yQsY3hV7WQTrf7h5yPMGKlAhik/b7g4/XUHt4Ipc14D LcsALTh7nqX9e2+Tf0NjTL8b2N9oxLDMVheuj9B3/MhpNEp6uK+OBUNWXECBV7+xTtJ8 ESVJzV1VeK9zToZy2tezzAWmIh8qaouue2MDB8L81U5EK+YsXbglb3Z0q8kNgwmB5c8i RC1kTXuoqvFRz3bc470C6mIrv5RgTBZGF9rzn5SR4/vHnqVETts+BSgDg36PlNheLKhP 1VdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gfdfOq3fPaEyVy8vIu1pAlj6ZJZ6BE3vB+0GWCKQYmQ=; b=VLCn2slqM2zjgudAQ6Ep96RNh0J3lFIZ9vna6mpbzzlTB81d1Qzb/xFaY5t2mO5b7W 7orF4pylHYBaQjkZsrLRVK3X5alMC4hAeeQqmX3YFy1xGCzObSUUSHjxYQ+9QwQDD1mq UWjOC7mccljiimcGUs5y5fjLUBtbS5qTEwqMFMO4OO6j8gP+BZWVREQgd4+6aWnokmxX j0qujGmnF7CoHK/iVgsx5Tim9IAIVdKBQlz0NfAtGx6gD1LuUnhSJD3+BNnmLQyfpwit qwiQRpVopiT3kC9boekAgzK9D2KeT+GnwvRtL6Ip1jx/o5r4j7PPV1b9VFVNxLOQOVes YC2g== X-Gm-Message-State: AOAM531OuEOb3T2jnnEK50N45woZ5YjImdeelf1iI2tGXZW9hL54fl/1 9x6ig3d4ISv7kYUpty7R25I= X-Google-Smtp-Source: ABdhPJwmDIiGavWc5Grj5GhdJlXCZr0tYjCpngDuINmooJu7VbSKMu2HCjYWhqVX3Nsg7RIw2/CuTw== X-Received: by 2002:adf:bc52:: with SMTP id a18mr8935589wrh.176.1628527853203; Mon, 09 Aug 2021 09:50:53 -0700 (PDT) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::996b]) by smtp.gmail.com with ESMTPSA id q5sm20484469wrx.33.2021.08.09.09.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Aug 2021 09:50:52 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH v2 08/17] staging: r8188eu: clean up comparsions to true/false Date: Mon, 9 Aug 2021 18:49:58 +0200 Message-Id: <20210809165007.23204-9-straube.linux@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210809165007.23204-1-straube.linux@gmail.com> References: <20210809165007.23204-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Clean up some comparsions to true/false to clear chackpatch warnings. WARNING: Unnecessary parentheses - maybe == should be = ? Signed-off-by: Michael Straube --- drivers/staging/r8188eu/core/rtw_ioctl_set.c | 4 ++-- drivers/staging/r8188eu/core/rtw_mlme.c | 2 +- drivers/staging/r8188eu/core/rtw_xmit.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_ioctl_set.c b/drivers/staging/r8188eu/core/rtw_ioctl_set.c index 1a4227729e0d..41c14a4cff1f 100644 --- a/drivers/staging/r8188eu/core/rtw_ioctl_set.c +++ b/drivers/staging/r8188eu/core/rtw_ioctl_set.c @@ -166,7 +166,7 @@ u8 rtw_set_802_11_bssid(struct adapter *padapter, u8 *bssid) rtw_free_assoc_resources(padapter, 1); - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) == true)) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) { _clr_fwstate_(pmlmepriv, WIFI_ADHOC_MASTER_STATE); set_fwstate(pmlmepriv, WIFI_ADHOC_STATE); } @@ -231,7 +231,7 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct ndis_802_11_ssid *ssid) if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE)) { if ((pmlmepriv->assoc_ssid.SsidLength == ssid->SsidLength) && (!memcmp(&pmlmepriv->assoc_ssid.Ssid, ssid->Ssid, ssid->SsidLength))) { - if ((check_fwstate(pmlmepriv, WIFI_STATION_STATE) == false)) { + if (!check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { if (!rtw_is_same_ibss(padapter, pnetwork)) { /* if in WIFI_ADHOC_MASTER_STATE | WIFI_ADHOC_STATE, create bss or rejoin again */ rtw_disassoc_cmd(padapter, 0, true); diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c index 4768d3ef350e..f28c30a6efb0 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -748,7 +748,7 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf) rtw_set_signal_stat_timer(&adapter->recvpriv); if (pmlmepriv->to_join) { - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { if (check_fwstate(pmlmepriv, _FW_LINKED) == false) { set_fwstate(pmlmepriv, _FW_UNDER_LINKING); diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c index 0a755d7b8f19..018ee20553dd 100644 --- a/drivers/staging/r8188eu/core/rtw_xmit.c +++ b/drivers/staging/r8188eu/core/rtw_xmit.c @@ -740,7 +740,7 @@ s32 rtw_make_wlanhdr (struct adapter *padapter, u8 *hdr, struct pkt_attrib *patt SetFrameSubType(fctrl, pattrib->subtype); if (pattrib->subtype & WIFI_DATA_TYPE) { - if ((check_fwstate(pmlmepriv, WIFI_STATION_STATE) == true)) { + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { /* to_ds = 1, fr_ds = 0; */ /* Data transfer to AP */ SetToDs(fctrl); -- 2.32.0