From: Dan Carpenter <dan.carpenter@oracle.com>
To: Evgeny Novikov <novikov@ispras.ru>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alex Dewar <alex.dewar90@gmail.com>,
Colin Ian King <colin.king@canonical.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH v2] media: atomisp: Fix error handling in probe
Date: Tue, 10 Aug 2021 21:47:17 +0300 [thread overview]
Message-ID: <20210810184717.GZ1931@kadam> (raw)
In-Reply-To: <20210810162943.19852-1-novikov@ispras.ru>
On Tue, Aug 10, 2021 at 07:29:43PM +0300, Evgeny Novikov wrote:
> There were several issues with handling errors in lm3554_probe():
> - Probe did not set the error code when v4l2_ctrl_handler_init() failed.
> - It intermixed gotos for handling errors of v4l2_ctrl_handler_init()
> and media_entity_pads_init().
> - It did not set the error code for failures of v4l2_ctrl_new_custom().
> - Probe did not free resources in case of failures of
> atomisp_register_i2c_module().
>
> The patch fixes all these issues.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Perfect. Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2021-08-10 18:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 16:29 [PATCH v2] media: atomisp: Fix error handling in probe Evgeny Novikov
2021-08-10 18:47 ` Dan Carpenter [this message]
2021-08-10 20:50 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210810184717.GZ1931@kadam \
--to=dan.carpenter@oracle.com \
--cc=alex.dewar90@gmail.com \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=ldv-project@linuxtesting.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=novikov@ispras.ru \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox