From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org
Subject: [PATCH V2 2/6] perf script: Fix unnecessary machine_resolve()
Date: Wed, 11 Aug 2021 13:10:32 +0300 [thread overview]
Message-ID: <20210811101036.17986-3-adrian.hunter@intel.com> (raw)
In-Reply-To: <20210811101036.17986-1-adrian.hunter@intel.com>
machine_resolve() may have already been called. Test for that to avoid
calling it again unnecessarily.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
tools/perf/builtin-script.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index e2e165b53499..f469354155f1 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -2212,7 +2212,7 @@ static int process_sample_event(struct perf_tool *tool,
if (filter_cpu(sample))
goto out_put;
- if (machine__resolve(machine, &al, sample) < 0) {
+ if (!al.thread && machine__resolve(machine, &al, sample) < 0) {
pr_err("problem processing %d event, skipping it.\n",
event->header.type);
ret = -1;
--
2.17.1
next prev parent reply other threads:[~2021-08-11 10:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 10:10 [PATCH V2 0/6] perf tools: Add dlfilter test Adrian Hunter
2021-08-11 10:10 ` [PATCH V2 1/6] perf script: Fix documented const'ness of perf_dlfilter_fns Adrian Hunter
2021-08-11 10:10 ` Adrian Hunter [this message]
2021-08-11 10:10 ` [PATCH V2 3/6] perf script: Fix --list-dlfilters documentation Adrian Hunter
2021-08-11 10:10 ` [PATCH V2 4/6] perf tools: Amend dlfilter documentation wrt library dependencies Adrian Hunter
2021-08-11 10:10 ` [PATCH V2 5/6] perf tools: Move perf_dlfilters.h in the source tree Adrian Hunter
2021-08-11 10:10 ` [PATCH V2 6/6] perf tools: Add dlfilter test Adrian Hunter
2021-08-11 12:38 ` [PATCH V2 0/6] " Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210811101036.17986-3-adrian.hunter@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox