From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16CDFC4338F for ; Thu, 12 Aug 2021 20:40:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFD89610CC for ; Thu, 12 Aug 2021 20:40:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231630AbhHLUlP (ORCPT ); Thu, 12 Aug 2021 16:41:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:39358 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232796AbhHLUlN (ORCPT ); Thu, 12 Aug 2021 16:41:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DC46C610A8; Thu, 12 Aug 2021 20:40:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628800847; bh=lTyo3EMRGZxkzDJQPlmoJfNWRHnKmZw70dp59KMeCIU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G+m6IC7F8tJFTgYWxuPfYaf5qn7EcwvIVJsTrQDsZO+TdvvtLxLtjyPhkMd8aOO56 qkjI+oBu4sCnFDc/QXPo5n3eWOEOA0ckEuW1Lzh/+RESjTc3mvssTAocMQPrifEdgq SrCjYFw+D4FvamI/m39Sg2WYPQbkOrsifSzTtHRCwpuQWRqQgZal0ZZj2hfzteB2QS 6UvFEaEkpIaMBtO17OzceyOhVP3f5+I+3tAPeua0ncvkOmtaquaZtHcD8ZTVmeShwJ cy/JuKCrPCNq/jrUZaiJu16iOvu8jXGykRhcfJqr+a85QyYkQ+i6wVxH3A+YTeMJ3u +Pr40Uz42YMDg== From: Nathan Chancellor To: Greg Kroah-Hartman , Phillip Potter , Larry Finger Cc: Nick Desaulniers , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Nathan Chancellor Subject: [PATCH 2/3] staging: r8188eu: Remove uninitialized use of ether_type in portctrl() Date: Thu, 12 Aug 2021 13:40:26 -0700 Message-Id: <20210812204027.338872-3-nathan@kernel.org> X-Mailer: git-send-email 2.33.0.rc2 In-Reply-To: <20210812204027.338872-1-nathan@kernel.org> References: <20210812204027.338872-1-nathan@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After commit 987219ad34a6 ("staging: r8188eu: remove lines from Makefile that silence build warnings"), clang warns: drivers/staging/r8188eu/core/rtw_recv.c:499:8: warning: variable 'ether_type' is uninitialized when used here [-Wuninitialized] if (ether_type == eapol_type) ^~~~~~~~~~ drivers/staging/r8188eu/core/rtw_recv.c:458:16: note: initialize the variable 'ether_type' to silence this warning u16 ether_type; ^ = 0 1 warning generated. This if statement sets the exact same assignment as above so just remove it. Signed-off-by: Nathan Chancellor --- drivers/staging/r8188eu/core/rtw_recv.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c index 9b3637e49052..8df38db9572c 100644 --- a/drivers/staging/r8188eu/core/rtw_recv.c +++ b/drivers/staging/r8188eu/core/rtw_recv.c @@ -495,10 +495,6 @@ static struct recv_frame *portctrl(struct adapter *adapter, struct recv_frame *p /* allowed */ /* check decryption status, and decrypt the frame if needed */ prtnframe = precv_frame; - /* check is the EAPOL frame or not (Rekey) */ - if (ether_type == eapol_type) - /* check Rekey */ - prtnframe = precv_frame; } } else { prtnframe = precv_frame; -- 2.33.0.rc2