From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48EF0C4338F for ; Mon, 16 Aug 2021 06:52:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B11E61A7A for ; Mon, 16 Aug 2021 06:52:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233699AbhHPGxK convert rfc822-to-8bit (ORCPT ); Mon, 16 Aug 2021 02:53:10 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:58809 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233349AbhHPGxI (ORCPT ); Mon, 16 Aug 2021 02:53:08 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 211171BF209; Mon, 16 Aug 2021 06:52:33 +0000 (UTC) Date: Mon, 16 Aug 2021 08:52:32 +0200 From: Miquel Raynal To: Clark Wang Cc: conor.culhane@silvaco.com, alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com Subject: Re: [PATCH V4 3/8] i3c: master: svc: separate err, fifo and disable interrupt of reset function Message-ID: <20210816085232.46682b0e@xps13> In-Reply-To: <20210809063645.2289988-4-xiaoning.wang@nxp.com> References: <20210809063645.2289988-1-xiaoning.wang@nxp.com> <20210809063645.2289988-4-xiaoning.wang@nxp.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Clark, Clark Wang wrote on Mon, 9 Aug 2021 14:36:40 +0800: > Sometimes only need to reset err and fifo regs, so split the origin > reset function to three functions. > Put them at the top of the file, to let more functions can call them. > > Signed-off-by: Clark Wang > Reviewed-by: Jun Li Reviewed-by: Miquel Raynal Thanks, Miquèl