From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AFB8C432BE for ; Mon, 16 Aug 2021 09:33:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 127CA61B5F for ; Mon, 16 Aug 2021 09:33:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235290AbhHPJeK (ORCPT ); Mon, 16 Aug 2021 05:34:10 -0400 Received: from verein.lst.de ([213.95.11.211]:53673 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbhHPJeK (ORCPT ); Mon, 16 Aug 2021 05:34:10 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 69EB467373; Mon, 16 Aug 2021 11:33:36 +0200 (CEST) Date: Mon, 16 Aug 2021 11:33:36 +0200 From: Christoph Hellwig To: Hillf Danton Cc: syzbot , axboe@kernel.dk, Christoph Hellwig , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] general protection fault in wb_timer_fn Message-ID: <20210816093336.GA3950@lst.de> References: <00000000000072e53a05c983ab22@google.com> <20210816091041.3313-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210816091041.3313-1-hdanton@sina.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 16, 2021 at 05:10:41PM +0800, Hillf Danton wrote: > Remove and free all qos callbacks added, with cb->timer deleted in > blk_stat_remove_callback(). > > only for thoughts. > > +++ x/block/blk-sysfs.c > @@ -800,9 +800,7 @@ static void blk_release_queue(struct kob > > might_sleep(); > > - if (test_bit(QUEUE_FLAG_POLL_STATS, &q->queue_flags)) > - blk_stat_remove_callback(q, q->poll_cb); > - blk_stat_free_callback(q->poll_cb); > + rq_qos_exit(q); rq_qos_exit is already called in blk_cleanup_queue, and the blk-mq pollig doesn't even use the qos framework. So I'm not sure what this is supposed to help.