Re: [PATCH 5.13 046/151] interconnect: qcom: icc-rpmh: Add BCMs to commit list in pre_aggregate

Greg Kroah-Hartman
2021-08-16T19:31:34Z

On Mon, Aug 16, 2021 at 08:17:52PM +0300, Georgi Djakov wrote:
> On 16.08.21 16:01, Greg Kroah-Hartman wrote:
> > From: Mike Tipton <mdtipton@codeaurora.org>
> >
> > [ Upstream commit f84f5b6f72e68bbaeb850b58ac167e4a3a47532a ]
> >
> > We're only adding BCMs to the commit list in aggregate(), but there are
> > cases where pre_aggregate() is called without subsequently calling
> > aggregate(). In particular, in icc_sync_state() when a node with initial
> > BW has zero requests. Since BCMs aren't added to the commit list in
> > these cases, we don't actually send the zero BW request to HW. So the
> > resources remain on unnecessarily.
> >
> > Add BCMs to the commit list in pre_aggregate() instead, which is always
> > called even when there are no requests.
> >
> > Fixes: 976daac4a1c5 ("interconnect: qcom: Consolidate interconnect RPMh support")
> > Signed-off-by: Mike Tipton <mdtipton@codeaurora.org>
> > Link: https://lore.kernel.org/r/20210721175432.2119-5-mdtipton@codeaurora.org
> > Signed-off-by: Georgi Djakov <djakov@kernel.org>
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
>
> Hello Greg and Sasha,
>
> Please drop this patch from both 5.10 and 5.13 stable queues. It's
> causing issues on some platforms and we are reverting in. Revert is
> in linux-next already.

Now dropped, thanks.

greg k-h