From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Leon Romanovsky <leon@kernel.org>, Joe Perches <joe@perches.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Andy Whitcroft <apw@canonical.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH] checkpatch: prefer = {} initializations to = {0}
Date: Mon, 16 Aug 2021 22:05:18 +0300 [thread overview]
Message-ID: <20210816190518.GK7722@kadam> (raw)
In-Reply-To: <20210816072344.GG22278@shell.armlinux.org.uk>
On Mon, Aug 16, 2021 at 08:23:45AM +0100, Russell King (Oracle) wrote:
> > That's out of date. It changed in C11. Both = { 0 } and = { } will
> > clear out struct holes. The = { } GCC extension has always initialized
> > struct holes.
> >
> > http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1548.pdf
> >
> > For partial initializations then all the padding is zeroed.
> > Unfortunately if you fully initialize the struct then padding is not
> > initialized.
>
> If we're going to discuss which C standard applies to the kernel,
> then...
>
> As Kbuild passes -std=gnu89, the kernel expects C89 behaviour with
> GNU extensions from the compiler, both C99 and C11 are not that
> relevant, although the GNU extensions include some bits from these
> standards.
That's fine. The GCC implementation has always been okay. The question
is if we could rely on it going forward so now that it's part of the
spec that's very reassuring.
regards,
dan carpenter
prev parent reply other threads:[~2021-08-16 19:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 10:43 [PATCH] checkpatch: prefer = {} initializations to = {0} Dan Carpenter
2021-08-05 12:27 ` Joe Perches
2021-08-05 18:04 ` Joe Perches
2021-08-05 18:17 ` Julia Lawall
2021-08-05 18:28 ` Joe Perches
2021-08-05 18:44 ` Julia Lawall
2021-08-14 13:59 ` Christophe JAILLET
2021-08-14 13:59 ` Christophe JAILLET
2021-08-14 14:05 ` Marion & Christophe JAILLET
2021-08-14 14:38 ` Leon Romanovsky
2021-08-14 14:57 ` Al Viro
2021-08-14 15:52 ` Leon Romanovsky
2021-08-14 16:45 ` Al Viro
2021-08-14 14:44 ` Russell King (Oracle)
2021-08-14 14:52 ` Al Viro
2021-08-14 20:20 ` Christophe JAILLET
2021-08-16 6:55 ` Dan Carpenter
2021-08-16 7:23 ` Russell King (Oracle)
2021-08-16 19:05 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210816190518.GK7722@kadam \
--to=dan.carpenter@oracle.com \
--cc=apw@canonical.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=julia.lawall@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukas.bulwahn@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox