From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>
Subject: drivers/net/dsa/ocelot/felix.c:1329 felix_check_xtr_pkt() error: uninitialized symbol 'err'.
Date: Mon, 16 Aug 2021 16:59:28 +0300 [thread overview]
Message-ID: <202108162120.F2VGdnZb-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7c60610d476766e128cc4284bb6349732cbd6606
commit: 0a6f17c6ae2116809a7b7eb6dd3eab59ef5460ef net: dsa: tag_ocelot_8021q: add support for PTP timestamping
config: ia64-randconfig-m031-20210816 (attached as .config)
compiler: ia64-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/dsa/ocelot/felix.c:1329 felix_check_xtr_pkt() error: uninitialized symbol 'err'.
vim +/err +1329 drivers/net/dsa/ocelot/felix.c
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1286 static bool felix_check_xtr_pkt(struct ocelot *ocelot, unsigned int ptp_type)
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1287 {
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1288 struct felix *felix = ocelot_to_felix(ocelot);
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1289 int err, grp = 0;
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1290
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1291 if (felix->tag_proto != DSA_TAG_PROTO_OCELOT_8021Q)
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1292 return false;
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1293
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1294 if (!felix->info->quirk_no_xtr_irq)
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1295 return false;
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1296
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1297 if (ptp_type == PTP_CLASS_NONE)
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1298 return false;
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1299
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1300 while (ocelot_read(ocelot, QS_XTR_DATA_PRESENT) & BIT(grp)) {
Smatch is complaining that this condition could be false on the first
iteration through the loop.
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1301 struct sk_buff *skb;
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1302 unsigned int type;
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1303
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1304 err = ocelot_xtr_poll_frame(ocelot, grp, &skb);
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1305 if (err)
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1306 goto out;
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1307
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1308 /* We trap to the CPU port module all PTP frames, but
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1309 * felix_rxtstamp() only gets called for event frames.
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1310 * So we need to avoid sending duplicate general
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1311 * message frames by running a second BPF classifier
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1312 * here and dropping those.
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1313 */
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1314 __skb_push(skb, ETH_HLEN);
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1315
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1316 type = ptp_classify_raw(skb);
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1317
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1318 __skb_pull(skb, ETH_HLEN);
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1319
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1320 if (type == PTP_CLASS_NONE) {
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1321 kfree_skb(skb);
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1322 continue;
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1323 }
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1324
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1325 netif_rx(skb);
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1326 }
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1327
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1328 out:
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 @1329 if (err < 0)
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1330 ocelot_drain_cpu_queue(ocelot, 0);
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1331
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1332 return true;
0a6f17c6ae2116 Vladimir Oltean 2021-02-14 1333 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next reply other threads:[~2021-08-16 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 13:59 Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-05 12:18 drivers/net/dsa/ocelot/felix.c:1329 felix_check_xtr_pkt() error: uninitialized symbol 'err' Dan Carpenter
2021-05-17 13:15 Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108162120.F2VGdnZb-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=f.fainelli@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox