From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A84BC432BE for ; Wed, 18 Aug 2021 16:39:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76FC2610A6 for ; Wed, 18 Aug 2021 16:39:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231901AbhHRQjx (ORCPT ); Wed, 18 Aug 2021 12:39:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:51734 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbhHRQjt (ORCPT ); Wed, 18 Aug 2021 12:39:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629304754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BZaLFXRzV9l0fgdri7hzFzPxavfz8D2UkZEnURZcUSE=; b=AMrGWJBgNJ/4DvORLv505gaGDEHh1gKJM82zh714u4nxctkiG0amWqU5ZgIdi+cgez5qvd t9A9dw9uV3OnrgPOYZLdLgoB7cRS07B14dmWCRvwRnNAMSNOsKvIoZ5610KHSenT2qIKpt jeCS/DaE6ADnflZHKN+1Ow3NKZp1GC4= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-521-C0dr5tL7OfGmcpbUQp8crg-1; Wed, 18 Aug 2021 12:39:12 -0400 X-MC-Unique: C0dr5tL7OfGmcpbUQp8crg-1 Received: by mail-ot1-f69.google.com with SMTP id 66-20020a9d0bc8000000b0051aa462e094so794120oth.9 for ; Wed, 18 Aug 2021 09:39:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BZaLFXRzV9l0fgdri7hzFzPxavfz8D2UkZEnURZcUSE=; b=HsU4y2g4XZtZsDAwhgaoq6XERGdn2+a4HVYWV6r7cap0bGfB+wQXqggWWtEtrFxVT8 SC+KvdqysQf8CpjFh8MXHWFUqghSp2k0fiUjrM99E20G7jpR1gn8Ng/oGGoGpPC8nOiy LnqeLRJ0VYQP98tvhmkpX/ooFr+xKtEZfybfkOk7u32zvEyCTckF33PxtHmzZIVTF0sP +wSiZ2C1jKZIwpdRRTReUmbFMFHuL13NgyfeRbZnlg8A5c7lZ2fnTUso43jky/WjpW+p NFcPHNzqAGuOB/t7F4YuCxjYiz2mtOwHz5HwHN4vVpDGDrP9Y3/UY4MpV1BhN7X7YCW7 4hRg== X-Gm-Message-State: AOAM531rqx2PrmLZ9nTBokR4vT7MOZaod63E05awGBcIbY4aeu14XSwn YeROKujy2MmbCWv6O7BCAofpkdRAW4requtKsuALH2O1wdjCM41fQp2jmQJDf36GQh9vnGkhPzm RefBlM5VgwgY+clanixXVOYbo X-Received: by 2002:a05:6830:913:: with SMTP id v19mr7650697ott.156.1629304752143; Wed, 18 Aug 2021 09:39:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsaGD1Dsv42EHMoGBypp5qPbWYWKQDHHY5MdTgQNhj+75F6/mx8z3kSdarO0OmQmDzK5F5xQ== X-Received: by 2002:a05:6830:913:: with SMTP id v19mr7650664ott.156.1629304751883; Wed, 18 Aug 2021 09:39:11 -0700 (PDT) Received: from redhat.com ([198.99.80.109]) by smtp.gmail.com with ESMTPSA id h14sm111621otm.5.2021.08.18.09.39.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 09:39:11 -0700 (PDT) Date: Wed, 18 Aug 2021 10:39:08 -0600 From: Alex Williamson To: Christian Borntraeger Cc: Tony Krowiak , Halil Pasic , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, cohuck@redhat.com, pasic@linux.vnet.ibm.com, jjherne@linux.ibm.com, jgg@nvidia.com, kwankhede@nvidia.com, david@redhat.com, pbonzini@redhat.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com Subject: Re: [PATCH 0/2] s390/vfio-ap: do not open code locks for VFIO_GROUP_NOTIFY_SET_KVM notification Message-ID: <20210818103908.31eb5848.alex.williamson@redhat.com> In-Reply-To: <6d64bd83-1519-6065-a4cd-9356c6be5d1a@de.ibm.com> References: <20210719193503.793910-1-akrowiak@linux.ibm.com> <3f45fe31-6666-ac87-3a98-dd942b5dfb3c@linux.ibm.com> <20210802155355.22b98789.pasic@linux.ibm.com> <6f37ef28-3cce-2f4f-3173-2c1e916900cc@linux.ibm.com> <6d64bd83-1519-6065-a4cd-9356c6be5d1a@de.ibm.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Aug 2021 17:59:51 +0200 Christian Borntraeger wrote: > On 02.08.21 18:32, Tony Krowiak wrote: > > > > > > On 8/2/21 9:53 AM, Halil Pasic wrote: > >> On Mon, 2 Aug 2021 09:10:26 -0400 > >> Tony Krowiak wrote: > >> > >>> PING! > >>> > >>> This patch will pre-req version 17 of a patch series I have waiting in > >>> the wings, > >>> so I'd like to get this one merged ASAP. In particular, if a KVM > >>> maintainer can > >>> take a look at the comments concerning the taking of the kvm->lock > >>> before the > >>> matrix_mdev->lock it would be greatly appreciated. Those comments begin with > >>> Message ID <20210727004329.3bcc7d4f.pasic@linux.ibm.com> from Halil Pasic. > >> As far as I'm concerned, we can move forward with this. Was this > >> supposed to go in via Alex's tree? > > > > I am not certain, Christian queued the previous patches related to > > this on: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/log/?h=fixes > > > > Jason G., since this will need to be integrated with your other patches, > > where should this be queued? > > > This previous patch (s390/vfio-ap: clean up mdev resources when remove callback invoked) is > already in master. > Can you respin the series with all Acks and RBs? > > Alex, can you then take these 2 patches via your tree? Thanks > > Acked-by: Christian Borntraeger > for this series. I see some review feedback that seems to suggest a new version would be posted: https://lore.kernel.org/linux-s390/0f03ab0b-2dfd-e1c1-fe43-be2a59030a71@linux.ibm.com/ I also see in this thread: https://lore.kernel.org/linux-s390/20210721164550.5402fe1c.pasic@linux.ibm.com/ that Halil's concern's around open/close races are addressed by Jason's device_open/close series that's already in my next branch and he provided an Ack, but there's still the above question regarding the kvm->lock that was looking for a review from... I'm not sure, maybe Connie or Paolo. Christian, is this specifically what you're ack'ing? It can ultimately go in through my tree, but not being familiar with this code I'd hope for more closure. Thanks, Alex