From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF481C432BE for ; Thu, 19 Aug 2021 06:19:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA57F61106 for ; Thu, 19 Aug 2021 06:19:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231279AbhHSGUL (ORCPT ); Thu, 19 Aug 2021 02:20:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230303AbhHSGUK (ORCPT ); Thu, 19 Aug 2021 02:20:10 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 647C8C061575 for ; Wed, 18 Aug 2021 23:19:34 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id a21so4516810pfh.5 for ; Wed, 18 Aug 2021 23:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nTW/BLkDiVzO1gHADZsi/9xVxK/pUSXQOI5etxdRSmo=; b=WDiDUjA/IkPmySU0d7mj3bP3Qc11FZOOw7DcXzrDxzvEG+BU8sQWn7Nna1tvYaBZzQ P2PYtiyMnFiLhJXN3Oya98MBxOqt6Sreu65Wth/4i3/qTPPFpLLijLqzHO3WG3UeYHta RG9N84mX5oXZTMSFDqnSmCvbnYlxRO34FdzW0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nTW/BLkDiVzO1gHADZsi/9xVxK/pUSXQOI5etxdRSmo=; b=scyBbBNndAqlsZ9JH/ofKhHvVrlyMy4WpP70Sw44POf6TxuGPNxPZc2ha1UukeausU tfa9I0YtjGNfzabjNnC155mPzmd57Sw0cM1Kt9BKTcQ73gp1NwJYriggGgiGmGJ2oWGn /zTQHFihN1Z7ToBjyfGjaQO6pUYN8cf6WNs+CdwcAu3hdxtevfb2qm9t7HXK+ObdU5kb 3NKV2YEuzlHve+WHrRWkn94msmDWtcpnLEWt9dFf3dEXexkNrP6Sn4bPW6QfRvYjNnbV Rfb22abPsDA9ZAIkcnyA/wTBBQp3uEbPth71wlrCE3lMhysEsbRW5Kni5yr+zUsAh1ej wBkw== X-Gm-Message-State: AOAM530Byi6UzWiHs0Vr9pJh9VC+X2llfUf9/ThZhJoN52AXInJouzoU aU53g/p9YPpqcdnRTM927DpenQ== X-Google-Smtp-Source: ABdhPJw1BHoL7ttU/DrhdxzeTEDNx3Dg+sBjOFPOFzkh7o2zft9bm56P9m5Pku6XXtfHdC3/dRpDSQ== X-Received: by 2002:a63:494:: with SMTP id 142mr12437314pge.242.1629353973971; Wed, 18 Aug 2021 23:19:33 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z1sm1983936pfg.18.2021.08.18.23.19.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 23:19:33 -0700 (PDT) Date: Wed, 18 Aug 2021 23:19:31 -0700 From: Kees Cook To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Sami Tolvanen , linux-kernel@vger.kernel.org, Michal Marek , Nick Desaulniers Subject: Re: [PATCH 04/13] kbuild: remove unused quiet_cmd_update_lto_symversions Message-ID: <202108182317.01AB60ECF9@keescook> References: <20210819005744.644908-1-masahiroy@kernel.org> <20210819005744.644908-5-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210819005744.644908-5-masahiroy@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 19, 2021 at 09:57:35AM +0900, Masahiro Yamada wrote: > This is not used anywhere. Ah-ha, I see: cmd_update_lto_symversions is never used through a $(call cmd, ...) invocation. Reviewed-by: Kees Cook -Kees > > Signed-off-by: Masahiro Yamada > --- > > scripts/Makefile.build | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > index 3e4cd1439cd4..279363266455 100644 > --- a/scripts/Makefile.build > +++ b/scripts/Makefile.build > @@ -411,7 +411,6 @@ $(subdir-builtin): $(obj)/%/built-in.a: $(obj)/% ; > $(subdir-modorder): $(obj)/%/modules.order: $(obj)/% ; > > # combine symversions for later processing > -quiet_cmd_update_lto_symversions = SYMVER $@ > ifeq ($(CONFIG_LTO_CLANG) $(CONFIG_MODVERSIONS),y y) > cmd_update_lto_symversions = \ > rm -f $@.symversions \ > -- > 2.30.2 > -- Kees Cook