From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FB6EC432BE for ; Fri, 20 Aug 2021 10:03:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 362DA610D2 for ; Fri, 20 Aug 2021 10:03:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238486AbhHTKDi (ORCPT ); Fri, 20 Aug 2021 06:03:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236384AbhHTKDg (ORCPT ); Fri, 20 Aug 2021 06:03:36 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56578C061575 for ; Fri, 20 Aug 2021 03:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5a1qUC1TDL7NB7yLQig36eoKmcE9tEaDzDiTiSTE4do=; b=bt5AgiwtluyVMfGoec2oCCGMRA +sa400FzGCgOKdlY3nZtVlxI2jmRk7v5rJT94E/lHmGJQ0k6XPsDZJ9FmDVk+Od1c7RFJsLRQG1Ge gPs26AGjDCDtDUG9XTg1ukCn+DfDre0bLT+GnJtY3ytRY7oqClFsfqr5hU1onvsaAtXeV4VaMkP8D EjdIwAUd5SC1pCMkZ+MEmlm+crvdq0laAdO8CyhPCii3jW7CRUnCBmJT4fqwdFTRXR/2ucWSWpoZM N1UNIXpYsMQ4YYoKWDM37jXcSzZNf1/2KgaDlQ4kwuT9QEmFuYoZITlaMkETitnMKdlyQQ9uDNkRz wQn4BE9w==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mH1MG-00BONu-AT; Fri, 20 Aug 2021 10:02:40 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 050639811F4; Fri, 20 Aug 2021 12:02:38 +0200 (CEST) Date: Fri, 20 Aug 2021 12:02:38 +0200 From: Peter Zijlstra To: Josh Don Cc: Eugene Syromiatnikov , Joel Fernandes , "Hyser,Chris" , Ingo Molnar , Vincent Guittot , Valentin Schneider , Mel Gorman , linux-kernel , Thomas Gleixner , Christian Brauner , ldv@strace.io Subject: Re: [PATCH] sched: Fix Core-wide rq->lock for uninitialized CPUs Message-ID: <20210820100238.GA2314@worktop.programming.kicks-ass.net> References: <20210422120459.447350175@infradead.org> <20210422123309.039845339@infradead.org> <20210817151542.GA1665@asgard.redhat.com> <20210817231734.GA4449@asgard.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 19, 2021 at 05:18:22PM -0700, Josh Don wrote: > Hi Peter, > > On Thu, Aug 19, 2021 at 4:09 AM Peter Zijlstra wrote: > > > > - /* shared state */ > > + /* shared state -- careful with sched_core_cpu_deactivate() */ > > Could also throw these fields into a wrapping struct. Either way seems fine. > > Reviewed-by: Josh Don Yes, I considered that, but didn't want the churn at this time.