From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B97DFC4338F for ; Sat, 21 Aug 2021 09:25:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A065861205 for ; Sat, 21 Aug 2021 09:25:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234101AbhHUJ0J (ORCPT ); Sat, 21 Aug 2021 05:26:09 -0400 Received: from elvis.franken.de ([193.175.24.41]:41941 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233311AbhHUJ0A (ORCPT ); Sat, 21 Aug 2021 05:26:00 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mHNFe-0005Uw-00; Sat, 21 Aug 2021 11:25:18 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 504C1C081C; Sat, 21 Aug 2021 10:40:52 +0200 (CEST) Date: Sat, 21 Aug 2021 10:40:52 +0200 From: Thomas Bogendoerfer To: Huilong Deng Cc: chenhuacai@kernel.org, aleksandar.qemu.devel@gmail.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: Return true/false (not 1/0) from bool functions Message-ID: <20210821084052.GA3555@alpha.franken.de> References: <20210817025338.3552-1-denghuilong@cdjrlc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210817025338.3552-1-denghuilong@cdjrlc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 17, 2021 at 10:53:38AM +0800, Huilong Deng wrote: > ./arch/mips/kernel/uprobes.c:261:8-9: WARNING: return of 0/1 in function > 'arch_uprobe_skip_sstep' with return type bool > ./arch/mips/kernel/uprobes.c:78:10-11: WARNING: return of 0/1 in > function 'is_trap_insn' with return type bool > ./arch/mips/kvm/mmu.c:489:9-10: WARNING: return of 0/1 in function > 'kvm_test_age_gfn' with return type bool > ./arch/mips/kvm/mmu.c:445:8-9: WARNING: return of 0/1 in function > 'kvm_unmap_gfn_range' with return type bool > > Signed-off-by: Huilong Deng > --- > arch/mips/kernel/uprobes.c | 10 +++++----- > arch/mips/kvm/mmu.c | 4 ++-- > 2 files changed, 7 insertions(+), 7 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]