From: Ariel Marcovitch <arielmarcovitch@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Ariel Marcovitch <arielmarcovitch@gmail.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] checkkconfigsymbols.py: Fix the '--ignore' option
Date: Sun, 22 Aug 2021 22:22:01 +0300 [thread overview]
Message-ID: <20210822192205.43210-2-arielmarcovitch@gmail.com> (raw)
In-Reply-To: <20210822192205.43210-1-arielmarcovitch@gmail.com>
It seems like the implementation of the --ignore option is broken.
In check_symbols_helper, when going through the list of files, a file is
added to the list of source files to check if it matches the ignore
pattern. Instead, as stated in the comment below this condition, the
file should be added if it doesn't match the pattern.
This means that when providing an ignore pattern, the only files that
will be checked will be the ones we want the ignore, in addition to the
Kconfig files that don't match the pattern (the check in
parse_kconfig_files is done right)
Signed-off-by: Ariel Marcovitch <arielmarcovitch@gmail.com>
---
scripts/checkkconfigsymbols.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkkconfigsymbols.py b/scripts/checkkconfigsymbols.py
index 1548f9ce4682..b9b0f15e5880 100755
--- a/scripts/checkkconfigsymbols.py
+++ b/scripts/checkkconfigsymbols.py
@@ -329,7 +329,7 @@ def check_symbols_helper(pool, ignore):
if REGEX_FILE_KCONFIG.match(gitfile):
kconfig_files.append(gitfile)
else:
- if ignore and not re.match(ignore, gitfile):
+ if ignore and re.match(ignore, gitfile):
continue
# add source files that do not match the ignore pattern
source_files.append(gitfile)
--
2.25.1
next prev parent reply other threads:[~2021-08-22 19:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 19:22 [PATCH 0/3] checkkconfigsymbols.py: Fix various bugs Ariel Marcovitch
2021-08-22 19:22 ` Ariel Marcovitch [this message]
2021-08-24 13:25 ` [PATCH 1/3] checkkconfigsymbols.py: Fix the '--ignore' option Masahiro Yamada
2021-08-22 19:22 ` [PATCH 2/3] checkkconfigsymbols.py: Fix Kconfig parsing to find 'if' lines Ariel Marcovitch
2021-08-24 13:30 ` Masahiro Yamada
2021-08-29 13:17 ` Ariel Marcovitch
2021-08-29 23:41 ` Masahiro Yamada
2021-09-01 15:17 ` Ariel Marcovitch
2021-08-22 19:22 ` [PATCH 3/3] checkkconfigsymbols.py: Forbid passing 'HEAD' to --commit Ariel Marcovitch
2021-08-24 13:31 ` Masahiro Yamada
2021-08-29 13:23 ` Ariel Marcovitch
2021-08-29 23:22 ` Masahiro Yamada
2021-08-24 13:23 ` [PATCH 0/3] checkkconfigsymbols.py: Fix various bugs Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210822192205.43210-2-arielmarcovitch@gmail.com \
--to=arielmarcovitch@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox