Re: [PATCH 0/8] staging: r8188eu: use is_multicast_ether_addr instead of IS_MCAST

Phillip Potter
2021-08-23T22:15:20Z

On Mon, 23 Aug 2021 at 13:02, Michael Straube <straube.linux@gmail.com> wrote:
>
> This series replaces most uses of the custom IS_MCAST macro with
> is_multicast_ether_addr. The goal is to get rid of IS_MCAST.
> There is only one usage left in rtw_sta_mgt.c, but that one needs
> more effort to verify that the buffers are properly aligned, so I
> left it as is for now.
>
> Michael Straube (8):
> staging: r8188eu: ensure proper alignment for eth address buffers
> staging: r8188eu: use is_multicast_ether_addr in core/rtw_mlme.c
> staging: r8188eu: use is_multicast_ether_addr in core/rtw_mp.c
> staging: r8188eu: use is_multicast_ether_addr in core/rtw_recv.c
> staging: r8188eu: use is_multicast_ether_addr in core/rtw_security.c
> staging: r8188eu: use is_multicast_ether_addr in core/rtw_xmit.c
> staging: r8188eu: use is_multicast_ether_addr in hal/rtl8188eu_xmit.c
> staging: r8188eu: use is_multicast_ether_addr in os_dep/recv_linux.c
>
> drivers/staging/r8188eu/core/rtw_mlme.c | 4 ++--
> drivers/staging/r8188eu/core/rtw_mp.c | 4 ++--
> drivers/staging/r8188eu/core/rtw_recv.c | 20 ++++++++++----------
> drivers/staging/r8188eu/core/rtw_security.c | 8 ++++----
> drivers/staging/r8188eu/core/rtw_xmit.c | 15 ++++++---------
> drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 3 +--
> drivers/staging/r8188eu/include/rtw_recv.h | 10 +++++-----
> drivers/staging/r8188eu/include/rtw_xmit.h | 8 ++++----
> drivers/staging/r8188eu/os_dep/recv_linux.c | 2 +-
> 9 files changed, 35 insertions(+), 39 deletions(-)
>
> --
> 2.32.0
>

Dear Michael,

Based on my limited knowledge, looks good to me. Also I built and
runtime tested it with my N10-Nano, driver works well still. Many
thanks.

For whole series:
Acked-by: Phillip Potter <phil@philpotter.co.uk>

Regards,
Phil