From: SeongJae Park <sj38.park@gmail.com>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Thara Gopinath <thara.gopinath@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: qcom-cpufreq-hw: Fix 'make allmodconfig' build
Date: Tue, 24 Aug 2021 09:14:30 +0000 [thread overview]
Message-ID: <20210824091430.20367-1-sjpark@amazon.de> (raw)
In-Reply-To: <440653.1629666844@turing-police>
Hi,
On Sun, 22 Aug 2021 17:14:04 -0400 "Valdis Klētnieks" <valdis.kletnieks@vt.edu> wrote:
>
> [-- Attachment #1: Type: text/plain, Size: 270 bytes --]
>
> On Sun, 22 Aug 2021 14:08:08 -0700, Randy Dunlap said:
>
> > This fixes one build error for me but I am still seeing another one:
> >
> > ERROR: modpost: "cpu_scale" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined!
>
> That's a different patch, am working on fixing that one now..
I didn't take a deep look here, so I unsure if this is an appropriate fix, but
I was able to work-around this issue for my use case with below change.
```
--- a/drivers/base/arch_topology.c
+++ b/drivers/base/arch_topology.c
@@ -149,6 +149,7 @@ void topology_set_freq_scale(const struct cpumask *cpus, unsigned long cur_freq,
}
DEFINE_PER_CPU(unsigned long, cpu_scale) = SCHED_CAPACITY_SCALE;
+EXPORT_PER_CPU_SYMBOL_GPL(cpu_scale);
void topology_set_cpu_scale(unsigned int cpu, unsigned long capacity)
{
```
Thanks,
SJ
next prev parent reply other threads:[~2021-08-24 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 20:10 [PATCH] cpufreq: qcom-cpufreq-hw: Fix 'make allmodconfig' build Valdis Klētnieks
2021-08-22 21:08 ` Randy Dunlap
2021-08-22 21:14 ` Valdis Klētnieks
2021-08-24 9:14 ` SeongJae Park [this message]
2021-08-25 2:16 ` Valdis Klētnieks
2021-08-25 4:41 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210824091430.20367-1-sjpark@amazon.de \
--to=sj38.park@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sudeep.holla@arm.com \
--cc=thara.gopinath@linaro.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox