From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66C65C4338F for ; Tue, 24 Aug 2021 15:19:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CA2D61265 for ; Tue, 24 Aug 2021 15:19:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238261AbhHXPUd (ORCPT ); Tue, 24 Aug 2021 11:20:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230341AbhHXPUb (ORCPT ); Tue, 24 Aug 2021 11:20:31 -0400 Received: from scorn.kernelslacker.org (scorn.kernelslacker.org [IPv6:2600:3c03:e000:2fb::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95AA7C061757 for ; Tue, 24 Aug 2021 08:19:47 -0700 (PDT) Received: from [2601:196:4600:6634:ae9e:17ff:feb7:72ca] (helo=wopr.kernelslacker.org) by scorn.kernelslacker.org with esmtp (Exim 4.92) (envelope-from ) id 1mIYDH-0000h4-KA; Tue, 24 Aug 2021 11:19:43 -0400 Received: by wopr.kernelslacker.org (Postfix, from userid 1026) id 3D1D656006F; Tue, 24 Aug 2021 11:19:43 -0400 (EDT) Date: Tue, 24 Aug 2021 11:19:43 -0400 From: Dave Jones To: Peter Zijlstra Cc: Linux Kernel , Johannes Weiner , Linus Torvalds Subject: Re: 5.14-rc breaks iotop swap io monitoring. Message-ID: <20210824151943.GA386@codemonkey.org.uk> Mail-Followup-To: Dave Jones , Peter Zijlstra , Linux Kernel , Johannes Weiner , Linus Torvalds References: <20210824031648.GA2725@codemonkey.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 24, 2021 at 10:31:16AM +0200, Peter Zijlstra wrote: > On Mon, Aug 23, 2021 at 11:16:48PM -0400, Dave Jones wrote: > > I just noticed that in 5.14-rc running iotop, it complains on startup > > that "CONFIG_TASK_DELAY_ACCT not enabled in kernel, cannot determine > > SWAPIN and IO %" and sure enough a bunch of columns show up as > > 'unavailable'. > > > > My suspicion is this commit, which I've not confirmed yet as it doesn't > > cleanly revert. I'll poke at it some more in the morning, but figured > > I'd bring it up sans-evidence in the hope that I'll wake up to someone > > having an Ah-ha moment. > > If you need DELAYACCT I'm thinking: > > e4042ad49235 ("delayacct: Default disabled") > > and > > 0cd7c741f01d ("delayacct: Add sysctl to enable at runtime") That does sound more relevant. however, even after echo 1 > /proc/sys/kernel/task_delayacct, it still fails in the same way. Dave