From: Mark Brown <broonie@kernel.org>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: Mark Hsieh <mark_hsieh@wistron.corp-partner.google.com>,
alsa-devel@alsa-project.org, kai.vehmanen@linux.intel.com,
pierre-louis.bossart@linux.intel.com, mac.chiang@intel.com,
lance.hou@intel.com, brent.lu@intel.com, bard.liao@intel.com,
liam.r.girdwood@linux.intel.com, yang.jie@linux.intel.com,
perex@perex.cz, linux-kernel@vger.kernel.org,
mark_hsieh@wistron.com
Subject: Re: [PATCH] [v2] ASoC: Intel: sof_rt5682: Add support for max98390 speaker amp
Date: Tue, 24 Aug 2021 16:32:11 +0100 [thread overview]
Message-ID: <20210824153211.GC4393@sirena.org.uk> (raw)
In-Reply-To: <a2cb1661-328f-81ac-813b-7629a28ed766@intel.com>
[-- Attachment #1: Type: text/plain, Size: 574 bytes --]
On Tue, Aug 24, 2021 at 03:59:44PM +0200, Cezary Rojewski wrote:
> On 2021-08-24 3:21 PM, Mark Hsieh wrote:
> > Configure adl_max98390_rt5682 to support the rt5682 headset codec and max98390 speaker
> Unsure if line-length for commit messages has been extended to 100 as it was
> the case for code parts but this line certainly exceeds default.
There's certainly no reason not to wrap this one. Even for code it's
not something to actively aim for.
> > BUG=b:191811888
> > TEST=emerge-brya chromeos-kernel-5_10
> Are these two tags meaningful for upstream kernel?
No.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-08-24 15:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 13:21 [PATCH] [v2] ASoC: Intel: sof_rt5682: Add support for max98390 speaker amp Mark Hsieh
2021-08-24 13:59 ` Cezary Rojewski
2021-08-24 15:32 ` Mark Brown [this message]
2021-08-24 16:22 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210824153211.GC4393@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=brent.lu@intel.com \
--cc=cezary.rojewski@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lance.hou@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=mark_hsieh@wistron.com \
--cc=mark_hsieh@wistron.corp-partner.google.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox