From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABD45C432BE for ; Tue, 24 Aug 2021 22:18:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E7216127B for ; Tue, 24 Aug 2021 22:18:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236863AbhHXWTH (ORCPT ); Tue, 24 Aug 2021 18:19:07 -0400 Received: from mga18.intel.com ([134.134.136.126]:55914 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229605AbhHXWTG (ORCPT ); Tue, 24 Aug 2021 18:19:06 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10086"; a="204543029" X-IronPort-AV: E=Sophos;i="5.84,348,1620716400"; d="scan'208";a="204543029" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2021 15:18:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,348,1620716400"; d="scan'208";a="493901200" Received: from lkp-server02.sh.intel.com (HELO 181e7be6f509) ([10.239.97.151]) by fmsmga008.fm.intel.com with ESMTP; 24 Aug 2021 15:18:18 -0700 Received: from kbuild by 181e7be6f509 with local (Exim 4.92) (envelope-from ) id 1mIekL-0000uB-Pb; Tue, 24 Aug 2021 22:18:17 +0000 Date: Wed, 25 Aug 2021 06:17:16 +0800 From: kernel test robot To: Oleksij Rempel Cc: kbuild-all@lists.01.org, Linux Memory Management List , Jakub Kicinski , Andrew Lunn , Colin Ian King , Grant Grundler , Heiner Kallweit , Oliver Neukum , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: usb: asix: ax88772: fix boolconv.cocci warnings Message-ID: <20210824221716.GA23759@2b586af07b64> References: <202108250651.uuW5Q2Rg-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202108250651.uuW5Q2Rg-lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kernel test robot drivers/net/usb/asix_devices.c:757:60-65: WARNING: conversion to bool not needed here Remove unneeded conversion to bool Semantic patch information: Relational and logical operators evaluate to bool, explicit conversion is overly verbose and unneeded. Generated by: scripts/coccinelle/misc/boolconv.cocci Fixes: 7a141e64cf14 ("net: usb: asix: ax88772: move embedded PHY detection as early as possible") CC: Oleksij Rempel Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 372b2891c15acbf7b90d948b08ac174bde77102c commit: 7a141e64cf14099d84e530db0e86fcb2c489e341 [9154/10077] net: usb: asix: ax88772: move embedded PHY detection as early as possible :::::: branch date: 12 hours ago :::::: commit date: 35 hours ago asix_devices.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/usb/asix_devices.c +++ b/drivers/net/usb/asix_devices.c @@ -754,7 +754,7 @@ static int ax88772_bind(struct usbnet *d return ret; priv->phy_addr = ret; - priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10 ? true : false); + priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10); asix_read_cmd(dev, AX_CMD_STATMNGSTS_REG, 0, 0, 1, &chipcode, 0); chipcode &= AX_CHIPCODE_MASK;