From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B3ECAC432BE
	for <linux-kernel@archiver.kernel.org>; Thu, 26 Aug 2021 05:37:24 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 86CC6610C7
	for <linux-kernel@archiver.kernel.org>; Thu, 26 Aug 2021 05:37:24 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S238178AbhHZFiK (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 26 Aug 2021 01:38:10 -0400
Received: from verein.lst.de ([213.95.11.211]:58081 "EHLO verein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229753AbhHZFiJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 26 Aug 2021 01:38:09 -0400
Received: by verein.lst.de (Postfix, from userid 2407)
        id 22FC06736F; Thu, 26 Aug 2021 07:37:20 +0200 (CEST)
Date:   Thu, 26 Aug 2021 07:37:19 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Nicholas Piggin <npiggin@gmail.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Christoph Hellwig <hch@lst.de>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 2/2] mm: don't allow executable ioremap mappings
Message-ID: <20210826053719.GA17085@lst.de>
References: <20210824091259.1324527-1-hch@lst.de> <20210824091259.1324527-3-hch@lst.de> <1629945413.hwbzjjtfbl.astroid@bobo.none>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1629945413.hwbzjjtfbl.astroid@bobo.none>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 26, 2021 at 12:46:34PM +1000, Nicholas Piggin wrote:
> I can't see why this is a problem. powerpcs can but it seems like a bad 
> idea anyway.
> 
> Any point to a WARN_ON or return -EINVAL? Hmm, maybe that doesn't work 
> for archs that don't support NX. We could add a check for ones that do 
> support it though... But that's for another patch.

This is the same as we do for regular vmap.  I can't remember why we
decided on this particular approach, as it's been a while.