From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 948EDC432BE for ; Sun, 29 Aug 2021 11:46:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76E2D60ED4 for ; Sun, 29 Aug 2021 11:46:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235252AbhH2LrD (ORCPT ); Sun, 29 Aug 2021 07:47:03 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:46696 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235143AbhH2LrC (ORCPT ); Sun, 29 Aug 2021 07:47:02 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1630237570; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=GfsV9Ojb7BBcgW10iYMoWARqBmNOVkCSIs35OVYOwgE=; b=n1tnbOlqatatzZXaNtoNB4Xpf0GOFmvow8KUGi/Q8CJZgbrbTGh+BUSRQfYlGRy6EEExSo38 W7RmBsFvOFJh5w4GBdV7mNf53K9XCt55mPBSmM6oX85GcnxWTpI78eiZLVO8SM9KApQNGUwA UDddTKdA1is9wCU22Xjpg/LugkI= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 612b736c6fc2cf7ad978d229 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sun, 29 Aug 2021 11:45:48 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 76F0BC4361B; Sun, 29 Aug 2021 11:45:47 +0000 (UTC) Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id A4F5CC43460; Sun, 29 Aug 2021 11:45:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org A4F5CC43460 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: brcmfmac: pcie: fix oops on failure to resume and reprobe From: Kalle Valo In-Reply-To: <20210817063521.22450-1-a.fatoum@pengutronix.de> References: <20210817063521.22450-1-a.fatoum@pengutronix.de> To: Ahmad Fatoum Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , kernel@pengutronix.de, Ahmad Fatoum , SHA-cyfmac-dev-list@infineon.com, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, Jakub Kicinski , "David S. Miller" , linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210829114547.76F0BC4361B@smtp.codeaurora.org> Date: Sun, 29 Aug 2021 11:45:47 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ahmad Fatoum wrote: > When resuming from suspend, brcmf_pcie_pm_leave_D3 will first attempt a > hot resume and then fall back to removing the PCI device and then > reprobing. If this probe fails, the kernel will oops, because brcmf_err, > which is called to report the failure will dereference the stale bus > pointer. Open code and use the default bus-less brcmf_err to avoid this. > > Fixes: 8602e62441ab ("brcmfmac: pass bus to the __brcmf_err() in pcie.c") > Signed-off-by: Ahmad Fatoum Patch applied to wireless-drivers-next.git, thanks. d745ca4f2c4a brcmfmac: pcie: fix oops on failure to resume and reprobe -- https://patchwork.kernel.org/project/linux-wireless/patch/20210817063521.22450-1-a.fatoum@pengutronix.de/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches