public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Robin H. Johnson" <robbat2@gentoo.org>
To: linux-kernel@vger.kernel.org
Cc: rostedt@goodmis.org, mingo@redhat.com, rjohnson@digitalocean.com,
	"Robin H. Johnson" <robbat2@gentoo.org>
Subject: [PATCH 1/2] tracing: show size of requested buffer
Date: Mon, 30 Aug 2021 21:37:22 -0700	[thread overview]
Message-ID: <20210831043723.13481-1-robbat2@gentoo.org> (raw)

If the perf buffer isn't large enough, provide a hint about how large it
needs to be for whatever is running.

Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
---
 kernel/trace/trace_event_perf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/trace/trace_event_perf.c b/kernel/trace/trace_event_perf.c
index 03be4435d103..26eed4b89100 100644
--- a/kernel/trace/trace_event_perf.c
+++ b/kernel/trace/trace_event_perf.c
@@ -400,7 +400,8 @@ void *perf_trace_buf_alloc(int size, struct pt_regs **regs, int *rctxp)
 	BUILD_BUG_ON(PERF_MAX_TRACE_SIZE % sizeof(unsigned long));
 
 	if (WARN_ONCE(size > PERF_MAX_TRACE_SIZE,
-		      "perf buffer not large enough"))
+		      "perf buffer not large enough, wanted %d, have %d",
+		      size, PERF_MAX_TRACE_SIZE))
 		return NULL;
 
 	*rctxp = rctx = perf_swevent_get_recursion_context();
-- 
2.33.0


             reply	other threads:[~2021-08-31  4:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31  4:37 Robin H. Johnson [this message]
2021-08-31  4:37 ` [PATCH 2/2] tracing: increase PERF_MAX_TRACE_SIZE to handle Sentinel1 and docker together Robin H. Johnson
2021-09-08  1:24 ` [PATCH 1/2] tracing: show size of requested buffer Steven Rostedt
2021-10-07  7:11   ` Peter Zijlstra
2021-10-07 13:23     ` Steven Rostedt
2021-10-07 17:26       ` Robin H. Johnson
2021-10-08 22:13         ` Steven Rostedt
2021-10-09  0:21           ` Robin H. Johnson
2021-10-26 20:43       ` Steven Rostedt
2021-10-26 21:23         ` Peter Zijlstra
2021-10-26 21:26           ` Steven Rostedt
2021-10-06 22:26 ` Steven Rostedt
2021-10-06 22:48   ` Robin H. Johnson
2021-10-07  0:55     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210831043723.13481-1-robbat2@gentoo.org \
    --to=robbat2@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rjohnson@digitalocean.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox