From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DEF4C4320A for ; Tue, 31 Aug 2021 17:40:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 669A4610A8 for ; Tue, 31 Aug 2021 17:40:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240469AbhHaRlg (ORCPT ); Tue, 31 Aug 2021 13:41:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233619AbhHaRld (ORCPT ); Tue, 31 Aug 2021 13:41:33 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24985C061575 for ; Tue, 31 Aug 2021 10:40:38 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id y17so2204447pfl.13 for ; Tue, 31 Aug 2021 10:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=e/lUs9VS8bNgCXkzAQ/A30iyRP/vIeFClAIrbPDNOgI=; b=ZWnE9DLc5a3Pa1cGrFEN7ht1umKjyp6cbkI2fIUDeGIPpB4NhXrDe+1d+3Abq5xJpB MnaJzTOhqBQOS1sKVtnXSB4OXSPlzmws6IzQtORVj6iJI+gL0y7ywcSoHsBZp58wJEEU CtbR/pjcQrghNCOhneHmolHtAe8C60P+JeR+s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e/lUs9VS8bNgCXkzAQ/A30iyRP/vIeFClAIrbPDNOgI=; b=X2rRtkTFfWMs0dK4ZZnhZxNmNtASlcPRiREsN2XAWj1wg5Ub9SjhBqZryvwCEqwTVl i/cmmeywt9qKENUjVtOp/9y+Q8YtOK37LiOzWjixS8e9L5xFvzV6mMaBLCbozcD/lvz7 b4qKlsOa7fnQrshRnYgmP1Ipc6c3+OFzUh4Z/IoiSwETGFHBeS9c269loTyIwA301MKH 8L7/z/pD0LyrgefYJWIC3Sz5rQccZV1LG7Vm9y/5cyRi6utz1KWrdeiSIpnS/kJ41/D5 na8OYEiu+fWcDllPULlL5X875nCfq9SW99XkthDPj5AD+4gQ50hW9UtcHx88QDkh9daS OMnQ== X-Gm-Message-State: AOAM531Kw3I4uO2ok6REn/XlKUq9GhFQviIMSJzYSnSWgcif+5F1KKla sQXm75MDwBQKmdhgPSrYGjuJDDgj7QIKow== X-Google-Smtp-Source: ABdhPJxEG61eVtEAivxMrdrhjEufs+36L8qK6bTIGFUMSD3vVgnPevrjXFvj0CakLIPE3k9vvkQUfA== X-Received: by 2002:a62:483:0:b0:3e2:8b7:8208 with SMTP id 125-20020a620483000000b003e208b78208mr29498588pfe.42.1630431622847; Tue, 31 Aug 2021 10:40:22 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id gk8sm1239537pjb.49.2021.08.31.10.40.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 10:40:22 -0700 (PDT) Date: Tue, 31 Aug 2021 10:40:21 -0700 From: Kees Cook To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Michal Marek , Nick Desaulniers , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/13] kbuild: rebuild modules when objtool is updated for CONFIG_LTO_CLANG Message-ID: <202108311040.1F8E65CC5D@keescook> References: <20210831074004.3195284-1-masahiroy@kernel.org> <20210831074004.3195284-11-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210831074004.3195284-11-masahiroy@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 31, 2021 at 04:40:01PM +0900, Masahiro Yamada wrote: > We rebuilt objects when objtool was updated, but only for non LTO > builds. > > For CONFIG_LTO_CLANG, the objtool step is postponed by the link time, > and nothing happens even if objtool is updated. > > Add the proper objtool dependency to the pre-modpost module link > for CONFIG_LTO_CLANG. > > Signed-off-by: Masahiro Yamada Reviewed-by: Kees Cook -- Kees Cook