Re: [PATCH v10 2/8] opp: Allow dev_pm_opp_set_clkname() to replace released clock

Viresh Kumar
2021-09-01T06:02:31Z

On 01-09-21, 08:46, Dmitry Osipenko wrote:
> 01.09.2021 07:42, Viresh Kumar пишет:
> > On 31-08-21, 16:54, Dmitry Osipenko wrote:
> >> The opp_table->clk is set to error once clock is released by
> >> dev_pm_opp_put_clkname(). This doesn't allow to set clock again,
> >
> > I am not sure why are you required to set the clk again here ? I mean,
> > users aren't expected to put clkname in the middle of using it. The
> > set-name API also checks that the OPP list should be empty in such a
> > case.
>
> I added explanatory comment to tegra_pmc_pd_dev_get_performance_state(),
> isn't it enough?

It confused me even more. Lemme comment there.

--
viresh