Re: [PATCH 6/7] fs/ntfs3: Change right headers to lznt.c

kernel test robot
2021-08-31T17:55:18Z

[-- Attachment #1: Type: text/plain, Size: 3789 bytes --]

Hi Kari,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20210831]
[cannot apply to linus/master v5.14 v5.14-rc7 v5.14-rc6 v5.14]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Kari-Argillander/fs-ntfs3-Refactor-header-includes/20210831-221738
base: 52c7b727581fe725f8b8a283af21fe0651c73c48
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/bb35516d85de116979ad1bbcb7a74b3a9b4eda6c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kari-Argillander/fs-ntfs3-Refactor-header-includes/20210831-221738
git checkout bb35516d85de116979ad1bbcb7a74b3a9b4eda6c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=sh

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

In file included from fs/ntfs3/lznt.c:14:
>> fs/ntfs3/debug.h:21:31: warning: 'struct super_block' declared inside parameter list will not be visible outside of this definition or declaration
21 | void ntfs_printk(const struct super_block *sb, const char *fmt, ...);
| ^~~~~~~~~~~
fs/ntfs3/ntfs_fs.h: In function 'ntfs_bread':
>> fs/ntfs3/ntfs_fs.h:1004:18: error: passing argument 1 of 'ntfs_printk' from incompatible pointer type [-Werror=incompatible-pointer-types]
1004 | ntfs_err(sb, "failed to read volume at offset 0x%llx",
| ^~
| |
| struct super_block *
fs/ntfs3/debug.h:40:45: note: in definition of macro 'ntfs_err'
40 | #define ntfs_err(sb, fmt, ...) ntfs_printk(sb, KERN_ERR fmt, ##__VA_ARGS__)
| ^~
fs/ntfs3/debug.h:21:44: note: expected 'const struct super_block *' but argument is of type 'struct super_block *'
21 | void ntfs_printk(const struct super_block *sb, const char *fmt, ...);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~^~
cc1: some warnings being treated as errors

vim +/ntfs_printk +1004 fs/ntfs3/ntfs_fs.h

4534a70b7056fd Konstantin Komarov 2021-08-13 995
4534a70b7056fd Konstantin Komarov 2021-08-13 996 static inline struct buffer_head *ntfs_bread(struct super_block *sb,
4534a70b7056fd Konstantin Komarov 2021-08-13 997 sector_t block)
4534a70b7056fd Konstantin Komarov 2021-08-13 998 {
4534a70b7056fd Konstantin Komarov 2021-08-13 999 struct buffer_head *bh = sb_bread(sb, block);
4534a70b7056fd Konstantin Komarov 2021-08-13 1000
4534a70b7056fd Konstantin Komarov 2021-08-13 1001 if (bh)
4534a70b7056fd Konstantin Komarov 2021-08-13 1002 return bh;
4534a70b7056fd Konstantin Komarov 2021-08-13 1003
4534a70b7056fd Konstantin Komarov 2021-08-13 @1004 ntfs_err(sb, "failed to read volume at offset 0x%llx",
4534a70b7056fd Konstantin Komarov 2021-08-13 1005 (u64)block << sb->s_blocksize_bits);
4534a70b7056fd Konstantin Komarov 2021-08-13 1006 return NULL;
4534a70b7056fd Konstantin Komarov 2021-08-13 1007 }
4534a70b7056fd Konstantin Komarov 2021-08-13 1008

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 55585 bytes --]