From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C460C432BE for ; Wed, 1 Sep 2021 15:14:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3401561053 for ; Wed, 1 Sep 2021 15:14:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245760AbhIAPPM (ORCPT ); Wed, 1 Sep 2021 11:15:12 -0400 Received: from outbound-smtp30.blacknight.com ([81.17.249.61]:60877 "EHLO outbound-smtp30.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245569AbhIAPPL (ORCPT ); Wed, 1 Sep 2021 11:15:11 -0400 Received: from mail.blacknight.com (pemlinmail03.blacknight.ie [81.17.254.16]) by outbound-smtp30.blacknight.com (Postfix) with ESMTPS id BEDA7BAF3F for ; Wed, 1 Sep 2021 16:14:13 +0100 (IST) Received: (qmail 19088 invoked from network); 1 Sep 2021 15:14:13 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.17.29]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 1 Sep 2021 15:14:13 -0000 Date: Wed, 1 Sep 2021 16:14:11 +0100 From: Mel Gorman To: Miaohe Lin Cc: akpm@linux-foundation.org, vbabka@suse.cz, sfr@canb.auug.org.au, peterz@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] mm/page_alloc.c: remove obsolete comment in free_pcppages_bulk() Message-ID: <20210901151411.GH4128@techsingularity.net> References: <20210830141051.64090-1-linmiaohe@huawei.com> <20210830141051.64090-4-linmiaohe@huawei.com> <20210831133830.GE4128@techsingularity.net> <884a4b72-95ab-0fca-6c74-d67535048736@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <884a4b72-95ab-0fca-6c74-d67535048736@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 01, 2021 at 03:49:03PM +0800, Miaohe Lin wrote: > On 2021/8/31 21:38, Mel Gorman wrote: > > On Mon, Aug 30, 2021 at 10:10:48PM +0800, Miaohe Lin wrote: > >> It's also confusing now. Remove it. > >> > > > > Why is the whole comment obsolete? > > > > The second two paragraphs about "all pages pinned" and pages_scanned is > > obsolete and can go but the first paragraph is valid. > > > > I think the first paragraph is invalid due to the below statement: > "Assumes all pages on list are in same zone, and of same order." > There are NR_PCP_LISTS lists and PAGE_ALLOC_COSTLY_ORDER + 1 + NR_PCP_THP > orders in pcp. So I think it's obsolete. > Ah. > Should I delete this statement in the first paragraph only? > Remove ", and of same order" -- Mel Gorman SUSE Labs