From: Alan Stern <stern@rowland.harvard.edu>
To: neal_liu <neal_liu@aspeedtech.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tony Prisk <linux@prisktech.co.nz>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Tao Ren <rentao.bupt@gmail.com>,
BMC-SW@aspeedtech.com
Subject: Re: [PATCH v2] usb: ehci: handshake CMD_RUN instead of STS_HALT
Date: Wed, 1 Sep 2021 12:41:07 -0400 [thread overview]
Message-ID: <20210901164107.GD404634@rowland.harvard.edu> (raw)
In-Reply-To: <20210901035041.10810-1-neal_liu@aspeedtech.com>
On Wed, Sep 01, 2021 at 11:50:41AM +0800, neal_liu wrote:
> Retitle.
>
> For Aspeed, HCHalted status depends on not only Run/Stop but also
> ASS/PSS status.
> Handshake CMD_RUN on startup instead.
>
> Signed-off-by: neal_liu <neal_liu@aspeedtech.com>
I'm still a little doubtful about doing this, but if you guys say it works
for your hardware then I guess it's okay.
Acked-by: Alan Stern <stern@rowland.harvard.edu>
> ---
> drivers/usb/host/ehci-hcd.c | 11 ++++++++++-
> drivers/usb/host/ehci-platform.c | 6 ++++++
> drivers/usb/host/ehci.h | 1 +
> 3 files changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 10b0365f3439..01c022e46aa2 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -634,7 +634,16 @@ static int ehci_run (struct usb_hcd *hcd)
> /* Wait until HC become operational */
> ehci_readl(ehci, &ehci->regs->command); /* unblock posted writes */
> msleep(5);
> - rc = ehci_handshake(ehci, &ehci->regs->status, STS_HALT, 0, 100 * 1000);
> +
> + /* For Aspeed, STS_HALT also depends on ASS/PSS status.
> + * Skip this check on startup.
> + */
> + if (ehci->is_aspeed)
> + rc = ehci_handshake(ehci, &ehci->regs->command, CMD_RUN,
> + 1, 100 * 1000);
> + else
> + rc = ehci_handshake(ehci, &ehci->regs->status, STS_HALT,
> + 0, 100 * 1000);
>
> up_write(&ehci_cf_port_reset_rwsem);
>
> diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
> index c70f2d0b4aaf..c3dc906274d9 100644
> --- a/drivers/usb/host/ehci-platform.c
> +++ b/drivers/usb/host/ehci-platform.c
> @@ -297,6 +297,12 @@ static int ehci_platform_probe(struct platform_device *dev)
> "has-transaction-translator"))
> hcd->has_tt = 1;
>
> + if (of_device_is_compatible(dev->dev.of_node,
> + "aspeed,ast2500-ehci") ||
> + of_device_is_compatible(dev->dev.of_node,
> + "aspeed,ast2600-ehci"))
> + ehci->is_aspeed = 1;
> +
> if (soc_device_match(quirk_poll_match))
> priv->quirk_poll = true;
>
> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> index 80bb823aa9fe..fdd073cc053b 100644
> --- a/drivers/usb/host/ehci.h
> +++ b/drivers/usb/host/ehci.h
> @@ -219,6 +219,7 @@ struct ehci_hcd { /* one per controller */
> unsigned need_oc_pp_cycle:1; /* MPC834X port power */
> unsigned imx28_write_fix:1; /* For Freescale i.MX28 */
> unsigned spurious_oc:1;
> + unsigned is_aspeed:1;
>
> /* required for usb32 quirk */
> #define OHCI_CTRL_HCFS (3 << 6)
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-09-01 16:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 3:50 [PATCH v2] usb: ehci: handshake CMD_RUN instead of STS_HALT neal_liu
2021-09-01 6:07 ` Greg Kroah-Hartman
2021-09-09 5:45 ` Tao Ren
2021-09-09 6:23 ` Neal Liu
2021-09-09 6:38 ` Greg Kroah-Hartman
2021-09-09 10:42 ` Neal Liu
2021-09-01 16:41 ` Alan Stern [this message]
2021-09-02 1:52 ` Neal Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210901164107.GD404634@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=BMC-SW@aspeedtech.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@prisktech.co.nz \
--cc=neal_liu@aspeedtech.com \
--cc=rentao.bupt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox