From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,TVD_SUBJ_WIPE_DEBT,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF257C433FE for ; Mon, 6 Sep 2021 18:26:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5BB66103B for ; Mon, 6 Sep 2021 18:26:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244988AbhIFS1l (ORCPT ); Mon, 6 Sep 2021 14:27:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244537AbhIFS02 (ORCPT ); Mon, 6 Sep 2021 14:26:28 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3106BC0612E7 for ; Mon, 6 Sep 2021 11:25:18 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id n27so14970122eja.5 for ; Mon, 06 Sep 2021 11:25:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PVe23R/MXbj1EQT1mw68UyAT1IyBFb9u3qdj7C6pqzY=; b=G4ov2cRPgl9DbjjTw5kDYo66aYKMQdjNzo0knh7SIW4R1uXyF8X7FTp059VLf7NkjE AOQgZPvtbcEocNjG7as/CbAOO9Kz/UJ7Z6aI/S83gCu1GD+qnnEuAH1irlVdIQ4r4ZM2 aBs9AhEpxBGOKSnacQbEEQPlZkzHMTGZ/PdlAIBDMNNW6KXXksqFRa7hvLCuHW2K4JIo EdbacqMviUouO8eoDC0/vJPcuzRPCxwcvRsu3agIuL9Uh1JGHyEh3sEwRSGVfOlDH/Nm hpHbmfrjyH7HE0lQhobXRYsZSoF8k8crLPhp2KDLotEp30imOyGxLq3xhJHeSLi/j+GW VAXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PVe23R/MXbj1EQT1mw68UyAT1IyBFb9u3qdj7C6pqzY=; b=V47y8CeUdhA9YXFeyuDYcwdU4E+q9Qu2jJF9mxD680oSmuRevl2FjOz4qmJ90Bg7/t 7STswQ6tsdzvd5uylkm1Ds37yOw4sc1/rAoARiCtKDRQ3tL97Umr8yZuP9hRGkYu89Hf Z8rZGR64cJTDCCehD3g2wuql63resa9GSaEXTaxNef/cPWrSdnqMUIjgxnSChDu+j4fv h10Nra9usk308jivurYg1nBR2WreTfpZpe1vFimDz35iI+fhl24VqFF9Hhjy2jV6L6gK Z34StlS8Vd08pgO+Lczl92YxJpM29H2/VXzYc45csYgDqNAt3WOHIdapGZzoiTsAL5Hz LxhA== X-Gm-Message-State: AOAM530iCH+yjgwtnYInapB6P/dc1NFnXqltDAPZ5fdmGi1HQXxuUhHw fQVmOayx0dWjHOjT7NxSRZI= X-Google-Smtp-Source: ABdhPJwRSLhP/uXLWasxU0qLhtkSgfY5KmaslI5IBDlGkLn4xC97s4fpGhRk/XO6UnSevEp9Cpsobg== X-Received: by 2002:a17:906:608e:: with SMTP id t14mr14848952ejj.441.1630952716846; Mon, 06 Sep 2021 11:25:16 -0700 (PDT) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::8fe1]) by smtp.gmail.com with ESMTPSA id s25sm4284492ejq.17.2021.09.06.11.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Sep 2021 11:25:16 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, martin@kaiser.cx, fmdefrancesco@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 21/40] staging: r8188eu: remove EfusePowerSwitch from hal_ops Date: Mon, 6 Sep 2021 20:24:19 +0200 Message-Id: <20210906182438.5417-22-straube.linux@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210906182438.5417-1-straube.linux@gmail.com> References: <20210906182438.5417-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove EfusePowerSwitch hal_ops and call rtl8188e_EfusePowerSwitch() directly instead. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/core/rtw_efuse.c | 2 +- drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 7 +------ drivers/staging/r8188eu/include/hal_intf.h | 4 ++-- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c b/drivers/staging/r8188eu/core/rtw_efuse.c index e1a9c031435b..8388ec60d21d 100644 --- a/drivers/staging/r8188eu/core/rtw_efuse.c +++ b/drivers/staging/r8188eu/core/rtw_efuse.c @@ -82,7 +82,7 @@ Efuse_PowerSwitch( u8 write, u8 PwrState) { - pAdapter->HalFunc.EfusePowerSwitch(pAdapter, write, PwrState); + rtl8188e_EfusePowerSwitch(pAdapter, write, PwrState); } /*----------------------------------------------------------------------------- diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c index 04c382e698f9..c7edb9ba4085 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c @@ -757,11 +757,7 @@ hal_EfusePowerSwitch_RTL8188E( } } -static void -rtl8188e_EfusePowerSwitch( - struct adapter *pAdapter, - u8 bWrite, - u8 PwrState) +void rtl8188e_EfusePowerSwitch(struct adapter *pAdapter, u8 bWrite, u8 PwrState) { hal_EfusePowerSwitch_RTL8188E(pAdapter, bWrite, PwrState); } @@ -1795,7 +1791,6 @@ void rtl8188e_set_hal_ops(struct hal_ops *pHalFunc) pHalFunc->write_rfreg = &rtl8188e_PHY_SetRFReg; /* Efuse related function */ - pHalFunc->EfusePowerSwitch = &rtl8188e_EfusePowerSwitch; pHalFunc->ReadEFuse = &rtl8188e_ReadEFuse; pHalFunc->EFUSEGetEfuseDefinition = &rtl8188e_EFUSE_GetEfuseDefinition; pHalFunc->EfuseGetCurrentSize = &rtl8188e_EfuseGetCurrentSize; diff --git a/drivers/staging/r8188eu/include/hal_intf.h b/drivers/staging/r8188eu/include/hal_intf.h index f85385cc9288..86456bac3a5a 100644 --- a/drivers/staging/r8188eu/include/hal_intf.h +++ b/drivers/staging/r8188eu/include/hal_intf.h @@ -177,8 +177,6 @@ struct hal_ops { enum rf_radio_path eRFPath, u32 RegAddr, u32 BitMask, u32 Data); - void (*EfusePowerSwitch)(struct adapter *padapter, u8 bWrite, - u8 PwrState); void (*ReadEFuse)(struct adapter *padapter, u8 efuseType, u16 _offset, u16 _size_byte, u8 *pbuf, bool bPseudoTest); void (*EFUSEGetEfuseDefinition)(struct adapter *padapter, u8 efuseType, @@ -221,6 +219,8 @@ void rtl8188e_SetHalODMVar(struct adapter *Adapter, enum hal_odm_variable eVariable, void *pValue1, bool bSet); u32 rtl8188eu_InitPowerOn(struct adapter *adapt); +void rtl8188e_EfusePowerSwitch(struct adapter *pAdapter, u8 bWrite, u8 PwrState); + void rtw_hal_free_data(struct adapter *padapter); uint rtw_hal_init(struct adapter *padapter); uint rtw_hal_deinit(struct adapter *padapter); -- 2.33.0