From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C8ECC433EF for ; Mon, 6 Sep 2021 19:04:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65F1F61057 for ; Mon, 6 Sep 2021 19:04:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343839AbhIFTFp (ORCPT ); Mon, 6 Sep 2021 15:05:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343680AbhIFTEV (ORCPT ); Mon, 6 Sep 2021 15:04:21 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 109D9C061575 for ; Mon, 6 Sep 2021 12:03:16 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id h9so15147418ejs.4 for ; Mon, 06 Sep 2021 12:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IEOqP/a3Ml1D77dDy56BnF0eXKCaiuHX10tPsGM0jZI=; b=YVVRc0+dtTO0rH6qckqMy3cOiYmRm74JKzIHgrYjinzk0StLRPHxeB0sOa4bkiBSg3 NhvMFa3n4YObV2vWjZ6oESVe2u8tohGORXkn4xWvMwTGNA9oUv5SwCA2S4iKE/227m5+ DDBDHX0m/mUxJG6nYMBpsFoSBL2z635oEdVcjUlLgq7gpA5AhG8nCmOwBorEIRzlF9v6 ORT8USLqzmdx4XmRdlkSbu40zObBwoFRHizHNrLL1rNxJAwAckOUOyBWutSOHtVvDkTQ egDz3jY5SQuOPN9hHJc4vlGSfmMhsoecX5mVRc1HhdHVvz1UFp/lf9Ojt6y4rBkRvELL RSEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IEOqP/a3Ml1D77dDy56BnF0eXKCaiuHX10tPsGM0jZI=; b=sbPx2O+bH6eNDLX2EM0m3+bf6LPkDsq9RgfLeDH6xPlw/t71VXvg2DOmIokI3YgOtx /YCNd88O0xWE1Ojpv0puOxUhC6gy5CbpAxSiFgI/TD3c+h2InEimEYz0hywFouHZZW0T rK2FN9Mw4jTeSnXlEamafGBmSLZZwomVwDracwZa4VoyCj9oMd84BlG7vKNIYGVRXbXf Sy+z/cmcE2MWIYjte7QE67Uwu5LOzSqkjzRfcvZV3w28KRWdp2DOaEssBXXac1DhnK68 yH38YVabgOwyvP4d9lYq0mj7fQpl5PMDJVdg6JkMrk2uk+wy2JKXiZslp8FgJKonoz05 o1Mg== X-Gm-Message-State: AOAM533OqRPDf1i2DNqqMah+ZsfW7wmnQPgYXvVISgt/V2m/QnDvpz0O b8qeG8aLS8mU9wtBWh5tgAo= X-Google-Smtp-Source: ABdhPJwU2y9NsU2KDRM1gdb/AW1E4RYtx720Jm8C9vFkloM4Tq9OFGsQXCWfhNW++C9uuO2Ra7XNWQ== X-Received: by 2002:a17:907:7f93:: with SMTP id qk19mr14372687ejc.433.1630954994646; Mon, 06 Sep 2021 12:03:14 -0700 (PDT) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::8fe1]) by smtp.gmail.com with ESMTPSA id k15sm4372018ejb.92.2021.09.06.12.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Sep 2021 12:03:14 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, martin@kaiser.cx, fmdefrancesco@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH v3 40/40] staging: r8188eu: remove UpdateHalRAMask8188EUsb from hal_ops Date: Mon, 6 Sep 2021 21:02:23 +0200 Message-Id: <20210906190223.11396-41-straube.linux@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210906190223.11396-1-straube.linux@gmail.com> References: <20210906190223.11396-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove UpdateHalRAMask8188EUsb from hal_ops and call UpdateHalRAMask8188EUsb() directly instead. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/hal_intf.c | 4 +--- drivers/staging/r8188eu/hal/usb_halinit.c | 4 +--- drivers/staging/r8188eu/include/hal_intf.h | 4 +--- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/staging/r8188eu/hal/hal_intf.c b/drivers/staging/r8188eu/hal/hal_intf.c index d38a8134b243..92c55b9ab244 100644 --- a/drivers/staging/r8188eu/hal/hal_intf.c +++ b/drivers/staging/r8188eu/hal/hal_intf.c @@ -139,9 +139,7 @@ void rtw_hal_update_ra_mask(struct adapter *adapt, u32 mac_id, u8 rssi_level) add_RATid(adapt, psta, 0);/* todo: based on rssi_level*/ #endif } else { - if (adapt->HalFunc.UpdateRAMaskHandler) - adapt->HalFunc.UpdateRAMaskHandler(adapt, mac_id, - rssi_level); + UpdateHalRAMask8188EUsb(adapt, mac_id, rssi_level); } } diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c index 4d60b5156995..37a976c56f06 100644 --- a/drivers/staging/r8188eu/hal/usb_halinit.c +++ b/drivers/staging/r8188eu/hal/usb_halinit.c @@ -2064,7 +2064,7 @@ static u8 SetHalDefVar8188EUsb(struct adapter *Adapter, enum hal_def_variable eV return bResult; } -static void UpdateHalRAMask8188EUsb(struct adapter *adapt, u32 mac_id, u8 rssi_level) +void UpdateHalRAMask8188EUsb(struct adapter *adapt, u32 mac_id, u8 rssi_level) { u8 init_rate = 0; u8 networkType, raid; @@ -2230,8 +2230,6 @@ void rtl8188eu_set_hal_ops(struct adapter *adapt) halfunc->GetHalDefVarHandler = &GetHalDefVar8188EUsb; halfunc->SetHalDefVarHandler = &SetHalDefVar8188EUsb; - halfunc->UpdateRAMaskHandler = &UpdateHalRAMask8188EUsb; - halfunc->hal_xmit = &rtl8188eu_hal_xmit; halfunc->mgnt_xmit = &rtl8188eu_mgnt_xmit; diff --git a/drivers/staging/r8188eu/include/hal_intf.h b/drivers/staging/r8188eu/include/hal_intf.h index 668a21cbe71e..727ef8511f64 100644 --- a/drivers/staging/r8188eu/include/hal_intf.h +++ b/drivers/staging/r8188eu/include/hal_intf.h @@ -147,9 +147,6 @@ struct hal_ops { enum hal_def_variable eVariable, void *pValue); - void (*UpdateRAMaskHandler)(struct adapter *padapter, - u32 mac_id, u8 rssi_level); - s32 (*hal_xmit)(struct adapter *padapter, struct xmit_frame *pxmitframe); s32 (*mgnt_xmit)(struct adapter *padapter, @@ -205,6 +202,7 @@ int rtl8188e_Efuse_PgPacketWrite(struct adapter *pAdapter, u8 offset, u8 word_en void hal_notch_filter_8188e(struct adapter *adapter, bool enable); void SetBeaconRelatedRegisters8188EUsb(struct adapter *adapt); +void UpdateHalRAMask8188EUsb(struct adapter *adapt, u32 mac_id, u8 rssi_level); uint rtw_hal_init(struct adapter *padapter); uint rtw_hal_deinit(struct adapter *padapter); -- 2.33.0