From: zhaoxiao <long870912@gmail.com>
To: thierry.reding@gmail.com, lee.jones@linaro.org
Cc: u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org,
linux-kernel@vger.kernel.org, zhaoxiao <long870912@gmail.com>
Subject: [PATCH] pwm: ab8500: Don't check the return code of pwmchip_remove()
Date: Wed, 8 Sep 2021 14:02:00 +0800 [thread overview]
Message-ID: <20210908060200.7876-1-long870912@gmail.com> (raw)
pwmchip_remove() returns always 0. Don't use the value to make it
possible to eventually change the function to return void. Also the
driver core ignores the return value of ab8500_pwm_remove()
and considers the device removed anyhow. So returning early results
in a resource leak.
Signed-off-by: zhaoxiao <long870912@gmail.com>
---
drivers/pwm/pwm-ab8500.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/pwm/pwm-ab8500.c b/drivers/pwm/pwm-ab8500.c
index e2a26d9da25b..51132a076f7f 100644
--- a/drivers/pwm/pwm-ab8500.c
+++ b/drivers/pwm/pwm-ab8500.c
@@ -113,11 +113,8 @@ static int ab8500_pwm_probe(struct platform_device *pdev)
static int ab8500_pwm_remove(struct platform_device *pdev)
{
struct ab8500_pwm_chip *ab8500 = platform_get_drvdata(pdev);
- int err;
- err = pwmchip_remove(&ab8500->chip);
- if (err < 0)
- return err;
+ pwmchip_remove(&ab8500->chip);
dev_dbg(&pdev->dev, "pwm driver removed\n");
--
2.20.1
next reply other threads:[~2021-09-08 6:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 6:02 zhaoxiao [this message]
2021-09-08 9:17 ` [PATCH] pwm: ab8500: Don't check the return code of pwmchip_remove() Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210908060200.7876-1-long870912@gmail.com \
--to=long870912@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox