RE: [PATCHv2] clk:aspeed:Fix AST2600 hpll calculate formula

Stephen Boyd
2021-09-15T01:17:33Z

Quoting Ryan Chen (2021-09-12 22:31:46)
> > > + if (hwstrap & BIT(10))
> > > + m = 0x5F;
> > > + else {
> > > + if (hwstrap & BIT(8))
> >
> > You may write it directly:
> > else if (hwstrap & BIT(8))
> >
> Hello,
> Like I commit message M = SCU500[10] ? 0x5F : SCU500[8] ? 0xBF : SCU200[12:0]
> it need keep from register read, if BIT(8)/BIT(10) not 1.
>

I don't get it. The review comment was that the else { if (...) can be
collapsed into an else if (..) What does commit message have to do with
it?