From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 473DEC433F5 for ; Thu, 9 Sep 2021 09:18:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D0AE610FF for ; Thu, 9 Sep 2021 09:18:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232594AbhIIJTj (ORCPT ); Thu, 9 Sep 2021 05:19:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:47101 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232344AbhIIJTh (ORCPT ); Thu, 9 Sep 2021 05:19:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631179108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Krg9n2n4lgxmyAY3a21a0zB1D/G0I7D/mxMTX6GAsu0=; b=TyPXTRSHe94X6YbqT9B4IEyLN57CuXHalZdYuYPjhrKX4t/Is+lusXqX6+LQcdEjA1BHzw bHLk1vkft3cV0egxV0xiVp4uZ0z/hHxuJMwTjaQyLcIzbCkmMKUdCKEXzKEmg3GSxDnm3Y JjquqVV2uxmyI0fkXGPJFMRc2D5DCAU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-274-GwuC6Js2Ot2fUbUQma4jhA-1; Thu, 09 Sep 2021 05:18:27 -0400 X-MC-Unique: GwuC6Js2Ot2fUbUQma4jhA-1 Received: by mail-wm1-f70.google.com with SMTP id g18-20020a1c4e12000000b002fa970d2d8dso490395wmh.0 for ; Thu, 09 Sep 2021 02:18:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Krg9n2n4lgxmyAY3a21a0zB1D/G0I7D/mxMTX6GAsu0=; b=AhHsWVaZqNdgoaOoIqP7jC1v6GnXAYOKVYNeFsPAtJkOrZOD20H8rmJQhESRwclOP6 XYnrgPyp47voONZ+eNqEb87L1Qmt4Ecnz01VX7/k+S/s7Jo9ueIqvklX/CuvJTBKcagW rcxeEtOHYde7+Rv4rdIQf4GIJEs+ngtMWOQFCz8L6CH62p0n3IRtC6hCo9EZuLmPFljv KRp2/Zc+QqTn2mHT/iXDp2CXTeiabmshwxLA/WuBSfZxusiSbbFn+8jO4nL5VGZMO93B oe8q3VJAU/+GSbvGo5+lwB0DAfP3xGzztZxHWFyMF8q4bph2gvl2EiqZcSj8W4C7IMA2 AI5g== X-Gm-Message-State: AOAM5336nW0mgjnaXU1WYolk2qNvjtHhPfbRohJkrwEM0YIGOnLefukb 0e5+O57QmNVSCo+Knyy6KAsG3W9mfpZyo3jDgzpvhb+qNtUGXqHKjJtxpmVcIHAzmbZ8yqS4bGw miBCuUifB5bi5OMtlP2ck/N3l X-Received: by 2002:adf:ea90:: with SMTP id s16mr2310722wrm.235.1631179105917; Thu, 09 Sep 2021 02:18:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFjAq21nDbpWPPjrbsJfaoxNYRTgyf2/ZBVzU5v/LEOsfI5v4OEI9flJnqQ6AXpadGjfF5Ug== X-Received: by 2002:adf:ea90:: with SMTP id s16mr2310707wrm.235.1631179105696; Thu, 09 Sep 2021 02:18:25 -0700 (PDT) Received: from redhat.com (bzq-84-108-84-219.cablep.bezeqint.net. [84.108.84.219]) by smtp.gmail.com with ESMTPSA id e8sm1263084wrc.96.2021.09.09.02.18.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 02:18:24 -0700 (PDT) Date: Thu, 9 Sep 2021 05:18:21 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: Wu Zongyong , virtualization , linux-kernel , wei.yang1@linux.alibaba.com Subject: Re: [PATCH 5/6] vdpa: add get_vq_num_unchangeable callback in vdpa_config_ops Message-ID: <20210909051706-mutt-send-email-mst@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 09, 2021 at 10:55:03AM +0800, Jason Wang wrote: > On Wed, Sep 8, 2021 at 8:23 PM Wu Zongyong wrote: > > > > This new callback is used to indicate whether the vring size can be > > change or not. It is useful when we have a legacy virtio pci device as > > the vdpa device for there is no way to negotiate the vring num by the > > specification. > > So I'm not sure it's worth bothering. E.g what if we just fail > VHOST_SET_VRING_NUM it the value doesn't match what hardware has? > > Thanks More importantly is there and actual plan for supporting legacy devices? I don't think they currently work at a number of levels. -- MST