Re: [PATCH AUTOSEL 5.14 044/252] staging: rtl8188eu: remove rtw_wx_set_rate handler function

Greg Kroah-Hartman
2021-09-09T12:20:57Z

On Thu, Sep 09, 2021 at 07:37:38AM -0400, Sasha Levin wrote:
> From: Phillip Potter <phil@philpotter.co.uk>
>
> [ Upstream commit ac5951a6e3d50cfa861ea83baa2ec15d994389cb ]
>
> Remove rtw_wx_set_rate handler function, which currently handles the
> SIOCSIWRATE wext ioctl. This function (although containing a lot of
> code) set nothing outside its own local variables, and did nothing other
> than call a now removed debugging statement repeatedly. Removing it and
> leaving its associated entry in rtw_handlers as NULL is therefore the
> better option. Removing this function also fixes a kernel test robot
> warning.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> Link: https://lore.kernel.org/r/20210625191658.1299-1-phil@philpotter.co.uk
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> .../staging/rtl8188eu/os_dep/ioctl_linux.c | 75 -------------------
> 1 file changed, 75 deletions(-)

This whole driver is now gone in 5.15-rc1, so no need for doing anything
like this for older kernels. Please drop this patch from all branches.

thanks,

greg k-h