Re: [PATCH AUTOSEL 5.4 22/37] MIPS: mscc: ocelot: mark the phy-mode for internal PHY ports

Vladimir Oltean
2021-09-12T10:14:41Z

Hi Sasha,

On Thu, Sep 09, 2021 at 08:21:27PM -0400, Sasha Levin wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> [ Upstream commit eba54cbb92d28b4f6dc1ed5f73f5187b09d82c08 ]
>
> The ocelot driver was converted to phylink, and that expects a valid
> phy_interface_t. Without a phy-mode, of_get_phy_mode returns
> PHY_INTERFACE_MODE_NA, which is not ideal because phylink rejects that.
>
> The ocelot driver was patched to treat PHY_INTERFACE_MODE_NA as
> PHY_INTERFACE_MODE_INTERNAL to work with the broken DT blobs, but we
> should fix the device trees and specify the phy-mode too.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---

Could you please drop this patch?

As discussed here, I did not bother to patch the ocelot switch driver on
stable kernels to support the new device tree binding too:
https://lore.kernel.org/lkml/YR6b15zKkjWFoM1X@piout.net/

So backporting the device tree change would break the old driver.