From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>, Sasha Levin <sashal@kernel.org>,
xen-devel@lists.xenproject.org
Subject: [PATCH AUTOSEL 4.19 22/25] xen: remove stray preempt_disable() from PV AP startup code
Date: Thu, 9 Sep 2021 20:22:30 -0400 [thread overview]
Message-ID: <20210910002234.176125-22-sashal@kernel.org> (raw)
In-Reply-To: <20210910002234.176125-1-sashal@kernel.org>
From: Juergen Gross <jgross@suse.com>
[ Upstream commit 58e636039b512697554b579c2bb23774061877f5 ]
In cpu_bringup() there is a call of preempt_disable() without a paired
preempt_enable(). This is not needed as interrupts are off initially.
Additionally this will result in early boot messages like:
BUG: scheduling while atomic: swapper/1/0/0x00000002
Signed-off-by: Juergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/20210825113158.11716-1-jgross@suse.com
Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/x86/xen/smp_pv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c
index 41fd4c123165..7b6e56703bb9 100644
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -59,7 +59,6 @@ static void cpu_bringup(void)
cpu_init();
touch_softlockup_watchdog();
- preempt_disable();
/* PVH runs in ring 0 and allows us to do native syscalls. Yay! */
if (!xen_feature(XENFEAT_supervisor_mode_kernel)) {
--
2.30.2
next prev parent reply other threads:[~2021-09-10 1:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 0:22 [PATCH AUTOSEL 4.19 01/25] clk: rockchip: rk3036: fix up the sclk_sfc parent error Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 02/25] scsi: smartpqi: Fix ISR accessing uninitialized data Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 03/25] scsi: lpfc: Fix cq_id truncation in rq create Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 04/25] clk: mediatek: Fix asymmetrical PLL enable and disable control Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 05/25] HID: usbhid: free raw_report buffers in usbhid_stop Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 06/25] f2fs: fix to force keeping write barrier for strict fsync mode Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 07/25] f2fs: fix min_seq_blocks can not make sense in some scenes Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 08/25] powerpc: make the install target not depend on any build artifact Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 09/25] jbd2: fix portability problems caused by unaligned accesses Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 10/25] scsi: qla2xxx: Fix NPIV create erroneous error Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 11/25] scsi: target: pscsi: Fix possible null-pointer dereference in pscsi_complete_cmd() Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 12/25] fs: dlm: fix return -EINTR on recovery stopped Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 13/25] scsi: core: Fix missing FORCE for scsi_devinfo_tbl.c build rule Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 14/25] powerpc/32: indirect function call use bctrl rather than blrl in ret_from_kernel_thread Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 15/25] powerpc/booke: Avoid link stack corruption in several places Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 16/25] KVM: PPC: Book3S HV: Initialise vcpu MSR with MSR_ME Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 17/25] KVM: PPC: Book3S HV P9: Fixes for TM softpatch interrupt NIP Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 18/25] RDMA/core/sa_query: Retry SA queries Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 19/25] platform/x86: dell-smbios-wmi: Avoid false-positive memcpy() warning Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 20/25] ext4: if zeroout fails fall back to splitting the extent node Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 21/25] ext4: Make sure quota files are not grabbed accidentally Sasha Levin
2021-09-10 0:22 ` Sasha Levin [this message]
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 23/25] checkkconfigsymbols.py: Fix the '--ignore' option Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 24/25] ocfs2: quota_local: fix possible uninitialized-variable access in ocfs2_local_read_info() Sasha Levin
2021-09-10 0:22 ` [PATCH AUTOSEL 4.19 25/25] ocfs2: ocfs2_downconvert_lock failure results in deadlock Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210910002234.176125-22-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox