From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F398C433FE for ; Fri, 10 Sep 2021 01:05:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 698606113A for ; Fri, 10 Sep 2021 01:05:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245414AbhIJBEw (ORCPT ); Thu, 9 Sep 2021 21:04:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:49792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234848AbhIJAYm (ORCPT ); Thu, 9 Sep 2021 20:24:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 60CB7611BF; Fri, 10 Sep 2021 00:23:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631233412; bh=2MjKKLz7JzePmBVcQDgPEuCsbqkT4iHdNk9yelbTGWk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CCsx7xpCr6g88miLZiMbIAMqW/KeFbGynaKDu/fWPrm9nB4OTJM5+18BO73W6XUAM N6B3hGIBLx8tT39U6qO2SJwAEJUpwPmw2nJzZxUh5Tq4FabdXG9MV6yu5GJo7goXnh 3kwR9u9TFP88/S34OmmWGrs3eRnMyBjoHkakS0mN9JB+p+A1oB/0WnfAd6ZzKJw+mo OR/WXihDPMlVjqNlN2VmLX4bELQeD8K4X9YoBAO6UXyFDESmiZsaV1g+xGL19VW6ig dj+3VdHVzJPFgJlLXnmUiNI0JHN0YD2xNwAzA+ZPx2VuIPEt+JPzJHkG7jWUieO9vG ZJAN/noPlfI7A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Juergen Gross , Sasha Levin , xen-devel@lists.xenproject.org Subject: [PATCH AUTOSEL 4.14 16/19] xen: remove stray preempt_disable() from PV AP startup code Date: Thu, 9 Sep 2021 20:23:06 -0400 Message-Id: <20210910002309.176412-16-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210910002309.176412-1-sashal@kernel.org> References: <20210910002309.176412-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Juergen Gross [ Upstream commit 58e636039b512697554b579c2bb23774061877f5 ] In cpu_bringup() there is a call of preempt_disable() without a paired preempt_enable(). This is not needed as interrupts are off initially. Additionally this will result in early boot messages like: BUG: scheduling while atomic: swapper/1/0/0x00000002 Signed-off-by: Juergen Gross Link: https://lore.kernel.org/r/20210825113158.11716-1-jgross@suse.com Signed-off-by: Juergen Gross Signed-off-by: Sasha Levin --- arch/x86/xen/smp_pv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c index f779d2a5b04c..44468d6fa188 100644 --- a/arch/x86/xen/smp_pv.c +++ b/arch/x86/xen/smp_pv.c @@ -59,7 +59,6 @@ static void cpu_bringup(void) cpu_init(); touch_softlockup_watchdog(); - preempt_disable(); /* PVH runs in ring 0 and allows us to do native syscalls. Yay! */ if (!xen_feature(XENFEAT_supervisor_mode_kernel)) { -- 2.30.2