From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34FF0C433F5 for ; Fri, 10 Sep 2021 01:05:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF449611BD for ; Fri, 10 Sep 2021 01:05:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245017AbhIJBEO (ORCPT ); Thu, 9 Sep 2021 21:04:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:49690 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbhIJAYc (ORCPT ); Thu, 9 Sep 2021 20:24:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0B73D604DC; Fri, 10 Sep 2021 00:23:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631233402; bh=/V5jojsyoL4A35v1c6UNigDRv6INtC87CW1+XJ1DYAc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pJApwqGCCgQDuRxw9Nz21HdHVTW12Loh1eUg29ZxNfvruIG/+T9vW4bb5GZ4sD5kz s5tl/CHaWO2S11/BYuQiSQDPpaicnquW0yHLS/IPH9PcgZo9+0hfGBAbBP7ClatEV3 10k8u2gg5wOe7Cm27syDogqyKZU1M0NKYplJQ/4/M0cFsto9DprIwB9LYNGmFhsjEI rcXRMS0tiyXKaBgl4nBUKo+Tsy1a/+alQMnI7urZL7LY8qEQpWfQK/B+iL8C+OzFPi WZQCzxD+ADDwzx+HTYUHQ+FFHKolPlra9qKBq4uHsFRILHT8fozcjpuljWGwdb9S19 s0KVnUHuujbtg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alexander Aring , Bob Peterson , David Teigland , Sasha Levin , cluster-devel@redhat.com Subject: [PATCH AUTOSEL 4.14 09/19] fs: dlm: fix return -EINTR on recovery stopped Date: Thu, 9 Sep 2021 20:22:59 -0400 Message-Id: <20210910002309.176412-9-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210910002309.176412-1-sashal@kernel.org> References: <20210910002309.176412-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander Aring [ Upstream commit aee742c9928ab4f5f4e0b00f41fb2d2cffae179e ] This patch will return -EINTR instead of 1 if recovery is stopped. In case of ping_members() the return value will be checked if the error is -EINTR for signaling another recovery was triggered and the whole recovery process will come to a clean end to process the next one. Returning 1 will abort the recovery process and can leave the recovery in a broken state. It was reported with the following kernel log message attached and a gfs2 mount stopped working: "dlm: bobvirt1: dlm_recover_members error 1" whereas 1 was returned because of a conversion of "dlm_recovery_stopped()" to an errno was missing which this patch will introduce. While on it all other possible missing errno conversions at other places were added as they are done as in other places. It might be worth to check the error case at this recovery level, because some of the functionality also returns -ENOBUFS and check why recovery ends in a broken state. However this will fix the issue if another recovery was triggered at some points of recovery handling. Reported-by: Bob Peterson Signed-off-by: Alexander Aring Signed-off-by: David Teigland Signed-off-by: Sasha Levin --- fs/dlm/dir.c | 4 +++- fs/dlm/member.c | 4 +++- fs/dlm/recoverd.c | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/fs/dlm/dir.c b/fs/dlm/dir.c index d975851a7e1e..c4de04ef8b01 100644 --- a/fs/dlm/dir.c +++ b/fs/dlm/dir.c @@ -87,8 +87,10 @@ int dlm_recover_directory(struct dlm_ls *ls) for (;;) { int left; error = dlm_recovery_stopped(ls); - if (error) + if (error) { + error = -EINTR; goto out_free; + } error = dlm_rcom_names(ls, memb->nodeid, last_name, last_len); diff --git a/fs/dlm/member.c b/fs/dlm/member.c index 0bc43b35d2c5..30f73cea20cc 100644 --- a/fs/dlm/member.c +++ b/fs/dlm/member.c @@ -435,8 +435,10 @@ static int ping_members(struct dlm_ls *ls) list_for_each_entry(memb, &ls->ls_nodes, list) { error = dlm_recovery_stopped(ls); - if (error) + if (error) { + error = -EINTR; break; + } error = dlm_rcom_status(ls, memb->nodeid, 0); if (error) break; diff --git a/fs/dlm/recoverd.c b/fs/dlm/recoverd.c index 6859b4bf971e..206c8b29429a 100644 --- a/fs/dlm/recoverd.c +++ b/fs/dlm/recoverd.c @@ -127,8 +127,10 @@ static int ls_recover(struct dlm_ls *ls, struct dlm_recover *rv) dlm_recover_waiters_pre(ls); error = dlm_recovery_stopped(ls); - if (error) + if (error) { + error = -EINTR; goto fail; + } if (neg || dlm_no_directory(ls)) { /* -- 2.30.2