Re: [PATCH] extcon: extcon-axp288: use low level P-Unit semaphore lock for axp288 register accesses

Fabio Aiuto
2021-09-10T07:14:02Z

Hi Hans,

On Fri, Sep 10, 2021 at 09:03:42AM +0200, Hans de Goede wrote:
> Hi,

<snip>

> > ^
> > 6 errors generated.
>
> Ah yes, I should have caught this, we had the same issue with a similar patch to
> the axp288-fuel-gauge driver.
>
> The fix is this:
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index c69d40ae5619..aab87c9b35c8 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -23,7 +23,7 @@ config EXTCON_ADC_JACK
>
> config EXTCON_AXP288
> tristate "X-Power AXP288 EXTCON support"
> - depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI
> + depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI && IOSF_MBI
> select USB_ROLE_SWITCH
> help
> Say Y here to enable support for USB peripheral detection
>
> The new depends on is fine since all boards which use the AXP288 should
> always have IOSF_MBI enabled anyways.
>
> Fabio, can you send a v2 with this Kconfig change added please ?
>
> (and please also add my earlier Reviewed-by and Tested-by to the v2)

sure will fix and resend

>
>
> >
> >

thank you,

fabio