From: Peter Zijlstra <peterz@infradead.org>
To: "Liang, Kan" <kan.liang@linux.intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Leo Yan <leo.yan@linaro.org>,
x86@kernel.org, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 1/3] perf/x86: Add new event for AUX output counter index
Date: Fri, 10 Sep 2021 18:04:09 +0200 [thread overview]
Message-ID: <20210910160409.GI4323@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <ab6f9ec2-2571-de5a-d44a-427851b08d19@linux.intel.com>
On Tue, Sep 07, 2021 at 01:45:22PM -0400, Liang, Kan wrote:
> On 9/7/2021 12:39 PM, Adrian Hunter wrote:
> > @@ -4494,8 +4500,16 @@ static int intel_pmu_check_period(struct perf_event *event, u64 value)
> > return intel_pmu_has_bts_period(event, value) ? -EINVAL : 0;
> > }
> > +static void intel_aux_output_init(void)
> > +{
> > + /* Refer also intel_pmu_aux_output_match() */
> > + if (x86_pmu.intel_cap.pebs_output_pt_available)
> > + x86_pmu.assign = intel_pmu_assign_event;
> > +}
>
> For a hybrid machine, x86_pmu.intel_cap.pebs_output_pt_available is always
> cleared. We probably need the PMU specific
> pmu->intel_cap.pebs_output_pt_available here.
>
> > +
> > static int intel_pmu_aux_output_match(struct perf_event *event)
> > {
> > + /* intel_pmu_assign_event() is needed, refer intel_aux_output_init() */
> > if (!x86_pmu.intel_cap.pebs_output_pt_available)
> > return 0;
> >
>
> For a hybrid machine, this always return 0. I think we need to fix it first?
AFAICT the patch is correct for !hybrid, and the hybrid PT muck can then
also fix this up, right?
next prev parent reply other threads:[~2021-09-10 16:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 16:39 [PATCH V3 0/3] perf intel-pt: Add PEBS-via-PT side-band Adrian Hunter
2021-09-07 16:39 ` [PATCH V3 1/3] perf/x86: Add new event for AUX output counter index Adrian Hunter
2021-09-07 17:45 ` Liang, Kan
2021-09-10 16:04 ` Peter Zijlstra [this message]
2021-09-10 16:29 ` Liang, Kan
2021-09-23 18:29 ` Adrian Hunter
2021-09-23 19:22 ` Alexander Shishkin
2021-10-13 9:12 ` Adrian Hunter
2021-10-13 14:17 ` Peter Zijlstra
2021-10-13 15:34 ` Arnaldo Carvalho de Melo
2021-10-15 9:31 ` [tip: perf/core] " tip-bot2 for Adrian Hunter
2021-09-07 16:39 ` [PATCH V3 2/3] perf tools: Add support for PERF_RECORD_AUX_OUTPUT_HW_ID Adrian Hunter
2021-09-07 16:39 ` [PATCH V3 3/3] perf intel-pt: " Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210910160409.GI4323@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox