From: Jason Gunthorpe <jgg@ziepe.ca>
To: Florian Eckert <fe@dev.tdt.de>
Cc: peterhuewe@gmx.de, jarkko@kernel.org,
Eckert.Florian@googlemail.com, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] tpm/tpm_i2c_infineon: Fix init endian vendor check
Date: Mon, 13 Sep 2021 11:03:02 -0300 [thread overview]
Message-ID: <20210913140302.GE3544071@ziepe.ca> (raw)
In-Reply-To: <690f5a5f846c4ef966713b4970d07737@dev.tdt.de>
On Mon, Sep 13, 2021 at 03:46:48PM +0200, Florian Eckert wrote:
> Hello Jason,
>
> > > The device works than as expected.
> > >
> > > Signed-off-by: Florian Eckert <fe@dev.tdt.de>
> > > v2:
> > > * use variable type instead of le32_to_cpus function call
> > > drivers/char/tpm/tpm_i2c_infineon.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > And if you do this it need to be made sparse clean/etc
>
> Sorry for the stupid question, but what exactly do you mean?
There is a tool called sparse that checks the endia notations and
verfies correctness
It will complain if you do
__le32 x
x = le32tocpu(x)
you neeed another variable to store the cpu version
Jason
next prev parent reply other threads:[~2021-09-13 15:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 12:05 [PATCH v2 1/1] tpm/tpm_i2c_infineon: Fix init endian vendor check Florian Eckert
2021-09-13 13:02 ` Jason Gunthorpe
2021-09-13 13:46 ` Florian Eckert
2021-09-13 14:03 ` Jason Gunthorpe [this message]
2021-09-13 18:31 ` kernel test robot
2021-09-13 20:31 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210913140302.GE3544071@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=Eckert.Florian@googlemail.com \
--cc=fe@dev.tdt.de \
--cc=jarkko@kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox