From: Mark Brown <broonie@kernel.org>
To: cy_huang <u0084500@gmail.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org, cy_huang@richtek.com
Subject: Re: [PATCH] regulator: rtq6752: Enclose 'enable' gpio control by enable flag
Date: Tue, 14 Sep 2021 15:07:47 +0100 [thread overview]
Message-ID: <20210914140747.GE4434@sirena.org.uk> (raw)
In-Reply-To: <1631627912-7974-1-git-send-email-u0084500@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 623 bytes --]
On Tue, Sep 14, 2021 at 09:58:32PM +0800, cy_huang wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> Fix 'enable' gpio control logic if it's specified.
>
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
> This patch is to prevent the logic error from the below cases.
>
> 1. All off and both are sequentially controlled to be on.
> The 'enable' gpio control block to be called twice including the delay time.
>
> 2. Both are on and one is preparing to be off.
> The 'enable' gpio control low before register cache is configured to be true.
This should be in the actual commit message.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-09-14 14:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 13:58 [PATCH] regulator: rtq6752: Enclose 'enable' gpio control by enable flag cy_huang
2021-09-14 14:07 ` Mark Brown [this message]
2021-09-14 14:11 ` ChiYuan Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210914140747.GE4434@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cy_huang@richtek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=u0084500@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox