Re: [PATCH v2 3/3] ARM: dts: mstar: Add the Wireless Tag IDO-SBC2D06-V1B-22W

Rob Herring
2021-09-21T21:14:53Z

On Tue, Sep 14, 2021 at 08:41:41PM +0200, Romain Perier wrote:
> The Wireless Tag IDO-SBC2D06-V1B-22W[1] is an SBC powered by SSD202D
> with a dual Ethernet and a connector for a 4-inch and 7-inch display.
> It embeds a System-On-Module IDO-SOM2D01[2] with an Mstar SSD202 SoC
> dual-core Cortex-A7 CPU @ 1.2Ghz , 2D GPU, 128 MB DDR3 (on-chip) and
> a 256MB SPI NAND flash. This commit adds basic definition for this
> board.
>
> 1. http://linux-chenxing.org/infinity2/ido-sbc2d06
> 2. http://www.wireless-tag.com/portfolio/ido-som2d01
>
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> ---
> .../devicetree/bindings/arm/mstar/mstar.yaml | 2 ++
> arch/arm/boot/dts/Makefile | 1 +
> .../dts/mstar-infinity2m-ssd201-som2d01.dtsi | 20 +++++++++++++
> ...sd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts | 23 +++++++++++++++
> ...ity2m-ssd202d-wirelesstag-ido-som2d01.dtsi | 28 +++++++++++++++++++
> 5 files changed, 74 insertions(+)
> create mode 100644 arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01.dtsi
> create mode 100644 arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts
> create mode 100644 arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi
>
> diff --git a/Documentation/devicetree/bindings/arm/mstar/mstar.yaml b/Documentation/devicetree/bindings/arm/mstar/mstar.yaml
> index a316eef1b728..10efd703717e 100644
> --- a/Documentation/devicetree/bindings/arm/mstar/mstar.yaml
> +++ b/Documentation/devicetree/bindings/arm/mstar/mstar.yaml
> @@ -25,6 +25,8 @@ properties:
> - enum:
> - honestar,ssd201htv2 # Honestar SSD201_HT_V2 devkit
> - m5stack,unitv2 # M5Stack UnitV2
> + - wirelesstag,ido-som2d01 # Wireless Tag IDO-SOM2D01
> + - wirelesstag,ido-sbc2d06-v1b-22w # Wireless Tag IDO-SBC2D06-1VB-22W
> - const: mstar,infinity2m
>
> - description: infinity3 boards
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 7e0934180724..7f0e92cea716 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1448,6 +1448,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += \
> dtb-$(CONFIG_ARCH_MILBEAUT) += milbeaut-m10v-evb.dtb
> dtb-$(CONFIG_ARCH_MSTARV7) += \
> mstar-infinity-msc313-breadbee_crust.dtb \
> + mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dtb \
> mstar-infinity2m-ssd202d-ssd201htv2.dtb \
> mstar-infinity2m-ssd202d-unitv2.dtb \
> mstar-infinity3-msc313e-breadbee.dtb \
> diff --git a/arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01.dtsi b/arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01.dtsi
> new file mode 100644
> index 000000000000..34df472fed71
> --- /dev/null
> +++ b/arch/arm/boot/dts/mstar-infinity2m-ssd201-som2d01.dtsi
> @@ -0,0 +1,20 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/*
> + * Copyright (c) 2021 thingy.jp.
> + * Author: Daniel Palmer <daniel@thingy.jp>
> + * Author: Romain Perier <romain.perier@gmail.com>
> + */
> +
> +/ {
> + reg_vcc_dram: regulator-vcc-dram {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc_dram";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-boot-on;
> + };
> +};
> +
> +&pm_uart {
> + status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts
> new file mode 100644
> index 000000000000..20b40b711d4f
> --- /dev/null
> +++ b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-sbc2d06-v1b-22w.dts
> @@ -0,0 +1,23 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/*
> + * Copyright (c) 2021 thingy.jp.
> + * Author: Daniel Palmer <daniel@thingy.jp>
> + * Author: Romain Perier <romain.perier@gmail.com>
> + */
> +
> +/dts-v1/;
> +#include "mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/ {
> + model = "Wireless Tag IDO-SBC2D06-1VB-22W";
> + compatible = "wirelesstag,ido-sbc2d06-v1b-22w", "wirelesstag,ido-som2d01", "mstar,infinity2m";

Doesn't match the schema. Please run 'make dtbs_check' on this and don't
add new (non-duplicate) warnings.

> +
> + leds {
> + compatible = "gpio-leds";
> + sys_led {
> + gpios = <&gpio SSD20XD_GPIO_GPIO85 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "heartbeat";
> + };
> + };
> +};
> diff --git a/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi
> new file mode 100644
> index 000000000000..d877aff85033
> --- /dev/null
> +++ b/arch/arm/boot/dts/mstar-infinity2m-ssd202d-wirelesstag-ido-som2d01.dtsi
> @@ -0,0 +1,28 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/*
> + * Copyright (c) 2021 thingy.jp.
> + * Author: Daniel Palmer <daniel@thingy.jp>
> + * Author: Romain Perier <romain.perier@gmail.com>
> + */
> +
> +/dts-v1/;
> +#include "mstar-infinity2m-ssd202d.dtsi"
> +#include "mstar-infinity2m-ssd201-som2d01.dtsi"
> +
> +/ {
> + model = "Wireless Tag IDO-SOM2D01 (SSD202D)";
> + compatible = "wirelesstag,ido-som2d01", "mstar,infinity2m";
> +
> + aliases {
> + serial0 = &pm_uart;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +};
> +
> +&reg_vcc_dram {
> + regulator-min-microvolt = <1500000>;
> + regulator-max-microvolt = <1500000>;
> +};
> --
> 2.33.0
>
>