From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-pwm@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
"Duc Nguyen" <duc.nguyen.ub@renesas.com>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lee Jones" <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] pwm: renesas-tpu: better errno for impossible rates
Date: Wed, 15 Sep 2021 08:55:40 +0200 [thread overview]
Message-ID: <20210915065542.1897-2-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20210915065542.1897-1-wsa+renesas@sang-engineering.com>
From: Duc Nguyen <duc.nguyen.ub@renesas.com>
ENOTSUP has confused users. EINVAL has been considered clearer. Change
the errno, we were the only ones using ENOTSUP in this subsystem anyhow.
Signed-off-by: Duc Nguyen <duc.nguyen.ub@renesas.com>
[wsa: split and reworded commit message]
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/pwm/pwm-renesas-tpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c
index 4381df90a527..754440194650 100644
--- a/drivers/pwm/pwm-renesas-tpu.c
+++ b/drivers/pwm/pwm-renesas-tpu.c
@@ -269,7 +269,7 @@ static int tpu_pwm_config(struct pwm_chip *chip, struct pwm_device *_pwm,
if (prescaler == ARRAY_SIZE(prescalers) || period == 0) {
dev_err(&tpu->pdev->dev, "clock rate mismatch\n");
- return -ENOTSUPP;
+ return -EINVAL;
}
if (duty_ns) {
--
2.30.2
next prev parent reply other threads:[~2021-09-15 6:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 6:55 [PATCH 0/2] pwm: renesas-tpu: minor improvements Wolfram Sang
2021-09-15 6:55 ` Wolfram Sang [this message]
2021-09-15 9:36 ` [PATCH 1/2] pwm: renesas-tpu: better errno for impossible rates Sergei Shtylyov
2021-09-17 8:25 ` Uwe Kleine-König
2021-09-20 9:08 ` Wolfram Sang
2021-09-15 6:55 ` [PATCH 2/2] pwm: renesas-tpu: don't allow no duty if duty_ns is given Wolfram Sang
2021-09-16 16:47 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915065542.1897-2-wsa+renesas@sang-engineering.com \
--to=wsa+renesas@sang-engineering.com \
--cc=duc.nguyen.ub@renesas.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).