From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C24BC433EF for ; Wed, 15 Sep 2021 07:48:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBF3460FC0 for ; Wed, 15 Sep 2021 07:48:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236614AbhIOHts (ORCPT ); Wed, 15 Sep 2021 03:49:48 -0400 Received: from verein.lst.de ([213.95.11.211]:35280 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231364AbhIOHtr (ORCPT ); Wed, 15 Sep 2021 03:49:47 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 5A2A768B05; Wed, 15 Sep 2021 09:48:27 +0200 (CEST) Date: Wed, 15 Sep 2021 09:48:27 +0200 From: Christoph Hellwig To: guoren@kernel.org Cc: anup.patel@wdc.com, atish.patra@wdc.com, palmerdabbelt@google.com, christoph.muellner@vrull.eu, philipp.tomsich@vrull.eu, hch@lst.de, liush@allwinnertech.com, wefu@redhat.com, lazyparser@gmail.com, drew@beagleboard.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, taiten.peng@canonical.com, aniket.ponkshe@canonical.com, heinrich.schuchardt@canonical.com, gordan.markus@canonical.com, Guo Ren Subject: Re: [RFC PATCH V4 3/6] RISC-V: Support a new config option for non-coherent DMA Message-ID: <20210915074827.GC20024@lst.de> References: <20210911092139.79607-1-guoren@kernel.org> <20210911092139.79607-4-guoren@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210911092139.79607-4-guoren@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 11, 2021 at 05:21:36PM +0800, guoren@kernel.org wrote: > + select DMA_GLOBAL_POOL > + select DMA_DIRECT_REMAP No need to select DMA_GLOBAL_POOL when DMA_DIRECT_REMAP is select. Also a patch just to add a option that is not selected and won't build if selected does not make sense.