Re: [PATCH 3/7] staging: vchiq_arm: clarify multiplication expressions

Joe Perches
2021-09-16T11:24:39Z

On Wed, 2021-09-15 at 17:18 -0300, Gaston Gonzalez wrote:
> Add spaces around '*' in multiplication expressions to enhance
> readability.
[]
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
[]
> @@ -466,8 +466,8 @@ int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state)
>
>   g_free_fragments = g_fragments_base;
>   for (i = 0; i < (MAX_FRAGMENTS - 1); i++) {
> - *(char **)&g_fragments_base[i*g_fragments_size] =
> - &g_fragments_base[(i + 1)*g_fragments_size];
> + *(char **)&g_fragments_base[i * g_fragments_size] =
> + &g_fragments_base[(i + 1) * g_fragments_size];
>   }
>   *(char **)&g_fragments_base[i * g_fragments_size] = NULL;

unrelated:

These '*(char **)&' uses are odd and thankfully rare constructs.