From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>, Vinod Koul <vkoul@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 16/30] ABI: sysfs-bus-soundwire-slave: use wildcards on What definitions
Date: Thu, 16 Sep 2021 18:47:57 +0200 [thread overview]
Message-ID: <20210916184757.4f0b3cbf@coco.lan> (raw)
In-Reply-To: <9a379f0a-e076-844c-fb5d-130359e36754@linux.intel.com>
Hi Pierre,
Em Thu, 16 Sep 2021 11:36:33 -0500
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> escreveu:
> On 9/16/21 3:59 AM, Mauro Carvalho Chehab wrote:
> > An "N" upper letter is not a wildcard, nor can easily be identified
> > by script, specially since the USB sysfs define things like.
> > bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl
> > to convert it into a Regex.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>
> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thanks!
>
> I also realized that we have a similar with the 'master' case
>
> more sysfs-bus-soundwire-master
> What: /sys/bus/soundwire/devices/sdw-master-N/revision
> /sys/bus/soundwire/devices/sdw-master-N/clk_stop_modes
> /sys/bus/soundwire/devices/sdw-master-N/clk_freq
> /sys/bus/soundwire/devices/sdw-master-N/clk_gears
> /sys/bus/soundwire/devices/sdw-master-N/default_col
> /sys/bus/soundwire/devices/sdw-master-N/default_frame_rate
> /sys/bus/soundwire/devices/sdw-master-N/default_row
> /sys/bus/soundwire/devices/sdw-master-N/dynamic_shape
> /sys/bus/soundwire/devices/sdw-master-N/err_threshold
> /sys/bus/soundwire/devices/sdw-master-N/max_clk_freq
>
> If there is an update we should modify this as well for consistency with
> sdw-master-<N>?
It is on patch 15/30:
https://lkml.org/lkml/2021/9/16/198
Regards,
Mauro
>
> > ---
> > .../ABI/testing/sysfs-bus-soundwire-slave | 60 +++++++++----------
> > 1 file changed, 30 insertions(+), 30 deletions(-)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-bus-soundwire-slave b/Documentation/ABI/testing/sysfs-bus-soundwire-slave
> > index d324aa0b678f..fbf55834dfee 100644
> > --- a/Documentation/ABI/testing/sysfs-bus-soundwire-slave
> > +++ b/Documentation/ABI/testing/sysfs-bus-soundwire-slave
> > @@ -64,37 +64,37 @@ Description: SoundWire Slave Data Port-0 DisCo properties.
> > Data port 0 are used by the bus to configure the Data Port 0.
> >
> >
> > -What: /sys/bus/soundwire/devices/sdw:.../dpN_src/max_word
> > - /sys/bus/soundwire/devices/sdw:.../dpN_src/min_word
> > - /sys/bus/soundwire/devices/sdw:.../dpN_src/words
> > - /sys/bus/soundwire/devices/sdw:.../dpN_src/type
> > - /sys/bus/soundwire/devices/sdw:.../dpN_src/max_grouping
> > - /sys/bus/soundwire/devices/sdw:.../dpN_src/simple_ch_prep_sm
> > - /sys/bus/soundwire/devices/sdw:.../dpN_src/ch_prep_timeout
> > - /sys/bus/soundwire/devices/sdw:.../dpN_src/imp_def_interrupts
> > - /sys/bus/soundwire/devices/sdw:.../dpN_src/min_ch
> > - /sys/bus/soundwire/devices/sdw:.../dpN_src/max_ch
> > - /sys/bus/soundwire/devices/sdw:.../dpN_src/channels
> > - /sys/bus/soundwire/devices/sdw:.../dpN_src/ch_combinations
> > - /sys/bus/soundwire/devices/sdw:.../dpN_src/max_async_buffer
> > - /sys/bus/soundwire/devices/sdw:.../dpN_src/block_pack_mode
> > - /sys/bus/soundwire/devices/sdw:.../dpN_src/port_encoding
> > +What: /sys/bus/soundwire/devices/sdw:.../dp<N>_src/max_word
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/min_word
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/words
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/type
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/max_grouping
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/simple_ch_prep_sm
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/ch_prep_timeout
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/imp_def_interrupts
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/min_ch
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/max_ch
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/channels
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/ch_combinations
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/max_async_buffer
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/block_pack_mode
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_src/port_encoding
> >
> > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/max_word
> > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/min_word
> > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/words
> > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/type
> > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/max_grouping
> > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/simple_ch_prep_sm
> > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/ch_prep_timeout
> > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/imp_def_interrupts
> > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/min_ch
> > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/max_ch
> > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/channels
> > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/ch_combinations
> > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/max_async_buffer
> > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/block_pack_mode
> > - /sys/bus/soundwire/devices/sdw:.../dpN_sink/port_encoding
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/max_word
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/min_word
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/words
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/type
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/max_grouping
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/simple_ch_prep_sm
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/ch_prep_timeout
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/imp_def_interrupts
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/min_ch
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/max_ch
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/channels
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/ch_combinations
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/max_async_buffer
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/block_pack_mode
> > + /sys/bus/soundwire/devices/sdw:.../dp<N>_sink/port_encoding
> >
> > Date: May 2020
> >
> >
Thanks,
Mauro
next prev parent reply other threads:[~2021-09-16 17:41 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 8:59 [PATCH v3 00/30]Change wildcards on ABI files Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 01/30] ABI: sysfs-bus-usb: better document variable argument Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 02/30] ABI: sysfs-tty: better document module name parameter Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 03/30] ABI: sysfs-kernel-slab: use a wildcard for the cache name Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 04/30] ABI: security: fix location for evm and ima_policy Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 05/30] ABI: sysfs-class-tpm: use wildcards for pcr-* nodes Mauro Carvalho Chehab
2021-09-16 15:59 ` Jarkko Sakkinen
2021-09-16 16:00 ` Jarkko Sakkinen
2021-09-16 16:06 ` Greg Kroah-Hartman
2021-09-16 8:59 ` [PATCH v3 06/30] ABI: sysfs-bus-rapidio: use wildcards on What definitions Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 07/30] ABI: sysfs-class-cxl: place "not in a guest" at description Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 08/30] ABI: sysfs-class-devfreq-event: use the right wildcards on What Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 09/30] ABI: sysfs-class-mic: use the right wildcards on What definitions Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 10/30] ABI: pstore: Fix What field Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 11/30] ABI: sysfs-class-typec: fix a typo on a " Mauro Carvalho Chehab
2021-09-16 11:47 ` Heikki Krogerus
2021-09-16 8:59 ` [PATCH v3 12/30] ABI: sysfs-ata: use a proper wildcard for ata_* Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 13/30] ABI: sysfs-class-infiniband: use wildcards on What definitions Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 14/30] ABI: sysfs-bus-pci: " Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 15/30] ABI: sysfs-bus-soundwire-master: " Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 16/30] ABI: sysfs-bus-soundwire-slave: " Mauro Carvalho Chehab
2021-09-16 16:36 ` Pierre-Louis Bossart
2021-09-16 16:47 ` Mauro Carvalho Chehab [this message]
2021-10-01 4:37 ` Vinod Koul
2021-10-01 4:36 ` Vinod Koul
2021-09-16 8:59 ` [PATCH v3 17/30] ABI: sysfs-class-gnss: " Mauro Carvalho Chehab
2021-09-20 9:40 ` Johan Hovold
2021-09-16 8:59 ` [PATCH v3 18/30] ABI: sysfs-class-mei: " Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 19/30] ABI: sysfs-class-mux: " Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 20/30] ABI: sysfs-class-pwm: " Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 21/30] ABI: sysfs-class-rc: " Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 22/30] ABI: sysfs-class-rc-nuvoton: " Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 23/30] ABI: sysfs-class-uwb_rc: " Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 24/30] ABI: sysfs-class-uwb_rc-wusbhc: " Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 25/30] ABI: sysfs-devices-platform-dock: " Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 26/30] ABI: sysfs-devices-system-cpu: " Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 27/30] ABI: sysfs-firmware-efi-esrt: " Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 28/30] ABI: sysfs-platform-sst-atom: " Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 29/30] ABI: sysfs-ptp: " Mauro Carvalho Chehab
2021-09-16 8:59 ` [PATCH v3 30/30] ABI: sysfs-class-rapidio: " Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210916184757.4f0b3cbf@coco.lan \
--to=mchehab+huawei@kernel.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox